Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding optional symbolic package to svFSIplus #238

Open
1 task done
zasexton opened this issue Aug 15, 2024 · 1 comment
Open
1 task done

Adding optional symbolic package to svFSIplus #238

zasexton opened this issue Aug 15, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@zasexton
Copy link
Contributor

Use Case

There is a need to include symbolic manipulation into svFSIplus for custom implementations of the advection-reaction-diffusion equation (and potentially future constitutive models). See #218 (comment)

Problem

Figuring out how to include a symbolic library in a way that is efficient and not cumbersome to the rest of the svFSIplus project will be important. Many such packages can be large, involving many other dependencies -- we do not want this.

Solution

We plan to optionally adopt SymEngine, which is a standalone fast C++ symbolic manipulation library, for the symbolic manipulation of custom reactive terms that may be explored in custom implementations of the advection-diffusion-reaction equation. We plan to include this library as an optional Fetch dependency during configuration using cmake's FetchContent functionality. This might also outline a good template for interfacing other packages with svFSIplus without having to explicitly include them in the code base.

Alternatives considered

None so far....other symbolic libraries are typically larger and more difficult to integrate.

Additional context

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct and Contributing Guidelines
@zasexton zasexton added the enhancement New feature or request label Aug 15, 2024
@zasexton zasexton self-assigned this Aug 15, 2024
@zasexton zasexton changed the title Major feature request: Remove this title with a descriptive title. Adding optional symbolic package to svFSIplus Aug 15, 2024
@zasexton
Copy link
Contributor Author

an initial implementation has been built that correctly compiles svFSIplus with symengine here: https://github.com/zasexton/svFSIplus_public/tree/add-symengine-%23238

@zasexton zasexton mentioned this issue Aug 20, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant