Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

svFSIplus does not test several data input formats #227

Open
1 task done
ktbolt opened this issue Jul 23, 2024 · 0 comments
Open
1 task done

svFSIplus does not test several data input formats #227

ktbolt opened this issue Jul 23, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@ktbolt
Copy link
Collaborator

ktbolt commented Jul 23, 2024

Description

As I am writing the svFSIplus file format documentation I have noticed that there are no test cases for several of the file formats that are supported

  • Fourier coefficients
  • Profile spatial data
  • Domains IDs in VTP format

I don't think the code implementing reading these formats has ever been tested.

Reproduction

Look at the tests.

Expected behavior

Do we want to write tests for this functionality and possibly (probably) debug the code or should we just remove support for this?

Additional context

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct and Contributing Guidelines
@ktbolt ktbolt added the bug Something isn't working label Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ktbolt