Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The tests/cases/fluid/pipe_RCR_3d/lumen_inlet.fcs file format is wrong #226

Open
1 task done
ktbolt opened this issue Jul 22, 2024 · 0 comments
Open
1 task done
Labels
bug Something isn't working

Comments

@ktbolt
Copy link
Collaborator

ktbolt commented Jul 22, 2024

Description

The file https://github.com/SimVascular/svFSIplus/blob/main/tests/cases/fluid/pipe_RCR_3d/lumen_inlet.fcs does not have the correct format for a file containing Fourier coefficients

    0.0000
    1.0000
    0.000000E+00
    0.000000E+00
    16
   -6.283185E+01    0.000000E+00
    6.263025E+01   -1.868984E-07
   -1.851028E-07    1.979808E-15
   -3.293147E-07    1.821408E-07
    2.967629E-07    4.499564E-17
   -7.134611E-07   -1.729158E-07
   -1.667927E-07    5.199497E-16
   -1.920733E-06    1.597801E-07
    5.066059E-08   -2.587250E-16
    9.364629E-07   -1.435117E-07
   -1.344913E-07    8.999129E-17
   -9.410540E-07    1.250477E-07
    1.921845E-07    2.874722E-17
    9.540060E-07   -1.054107E-07
   -9.547580E-08   -1.106526E-16
    1.016783E-06    8.563008E-08

Reproduction

Look at the file.

Expected behavior

I think the file format is

InitialTime Period
InitialValue1 InitialValue2 ... InitialValue_NDIM 
TimeDerivativeLinearPart1 TimeDerivativeLinearPart2 ... TimeDerivativeLinearPart_NDIM
NumberOfFourierModes
RealPart1 ImaginaryPart1
...

Additional context

Note that README file for this test case is also wrong.

I don't think this has ever been tested.

Code of Conduct

  • I agree to follow this project's Code of Conduct and Contributing Guidelines
@ktbolt ktbolt added the bug Something isn't working label Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant