From aca9a10dc5dce2614355ce5b8a755c2eaaa13a37 Mon Sep 17 00:00:00 2001 From: Aaron Brown <71424733+aabrown100-git@users.noreply.github.com> Date: Thu, 26 Sep 2024 10:28:27 -0700 Subject: [PATCH] Solid viscosity default value bug (#270) * Change solid_viscosity default value to 0.0 * Update test case reference results, remove Viscosity in some xml files (which sets the fluid viscosity parameter and therefore has no effect) --- Code/Source/svFSI/Parameters.cpp | 2 +- tests/cases/fsi/pipe_3d/result_005.vtu | 4 ++-- tests/cases/fsi/pipe_3d_petsc/result_005.vtu | 4 ++-- tests/cases/fsi/pipe_3d_trilinos_bj/result_005.vtu | 4 ++-- tests/cases/fsi/pipe_3d_trilinos_ml/result_005.vtu | 4 ++-- tests/cases/struct/LV_Guccione_passive/result_001.vtu | 4 ++-- tests/cases/struct/LV_Holzapfel_passive/result_001.vtu | 4 ++-- tests/cases/struct/LV_Holzapfel_passive/svFSIplus.xml | 3 --- tests/cases/struct/LV_NeoHookean_passive/result_005.vtu | 4 ++-- tests/cases/struct/LV_NeoHookean_passive/svFSIplus.xml | 3 --- tests/cases/struct/LV_NeoHookean_passive_genBC/result_003.vtu | 4 ++-- tests/cases/struct/LV_NeoHookean_passive_genBC/svFSIplus.xml | 3 --- tests/cases/struct/LV_NeoHookean_passive_sv0D/result_003.vtu | 4 ++-- tests/cases/struct/LV_NeoHookean_passive_sv0D/svFSIplus.xml | 3 --- tests/cases/struct/block_compression/result_001.vtu | 4 ++-- tests/cases/struct/robin/result_001.vtu | 4 ++-- .../struct/tensile_adventitia_Guccione_active/result_002.vtu | 4 ++-- tests/cases/ustruct/LV_Guccione_active/result_001.vtu | 4 ++-- .../cases/ustruct/LV_NeoHookean_passive_genBC/result_003.vtu | 4 ++-- tests/cases/ustruct/LV_NeoHookean_passive_genBC/svFSIplus.xml | 3 --- tests/cases/ustruct/LV_NeoHookean_passive_sv0D/result_003.vtu | 4 ++-- tests/cases/ustruct/LV_NeoHookean_passive_sv0D/svFSIplus.xml | 3 --- tests/cases/ustruct/block_compression/P1P1_VMS/result_001.vtu | 4 ++-- tests/cases/ustruct/tensile_adventitia_HGO/result_001.vtu | 4 ++-- 24 files changed, 35 insertions(+), 53 deletions(-) diff --git a/Code/Source/svFSI/Parameters.cpp b/Code/Source/svFSI/Parameters.cpp index 95ccb340..72afc07d 100644 --- a/Code/Source/svFSI/Parameters.cpp +++ b/Code/Source/svFSI/Parameters.cpp @@ -1299,7 +1299,7 @@ DomainParameters::DomainParameters() set_parameter("Relative_tolerance", 1e-4, !required, relative_tolerance); set_parameter("Shell_thickness", 0.0, !required, shell_thickness); set_parameter("Solid_density", 0.5, !required, solid_density); - set_parameter("Solid_viscosity", 0.9, !required, solid_viscosity); + set_parameter("Solid_viscosity", 0.0, !required, solid_viscosity); set_parameter("Source_term", 0.0, !required, source_term); set_parameter("Time_step_for_integration", 0.0, !required, time_step_for_integration); } diff --git a/tests/cases/fsi/pipe_3d/result_005.vtu b/tests/cases/fsi/pipe_3d/result_005.vtu index b3c68f1b..40c7adca 100644 --- a/tests/cases/fsi/pipe_3d/result_005.vtu +++ b/tests/cases/fsi/pipe_3d/result_005.vtu @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:2c5e0a10e6c3f30addeb8595c27f531146fdf22e7d00e132c2b5b6cd01adfd89 -size 208368 +oid sha256:ceccd8ba7067b8b894ae6a192117af6c3659890a850dd951995620c30f5eaffd +size 210065 diff --git a/tests/cases/fsi/pipe_3d_petsc/result_005.vtu b/tests/cases/fsi/pipe_3d_petsc/result_005.vtu index b3c68f1b..40c7adca 100644 --- a/tests/cases/fsi/pipe_3d_petsc/result_005.vtu +++ b/tests/cases/fsi/pipe_3d_petsc/result_005.vtu @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:2c5e0a10e6c3f30addeb8595c27f531146fdf22e7d00e132c2b5b6cd01adfd89 -size 208368 +oid sha256:ceccd8ba7067b8b894ae6a192117af6c3659890a850dd951995620c30f5eaffd +size 210065 diff --git a/tests/cases/fsi/pipe_3d_trilinos_bj/result_005.vtu b/tests/cases/fsi/pipe_3d_trilinos_bj/result_005.vtu index b3c68f1b..40c7adca 100644 --- a/tests/cases/fsi/pipe_3d_trilinos_bj/result_005.vtu +++ b/tests/cases/fsi/pipe_3d_trilinos_bj/result_005.vtu @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:2c5e0a10e6c3f30addeb8595c27f531146fdf22e7d00e132c2b5b6cd01adfd89 -size 208368 +oid sha256:ceccd8ba7067b8b894ae6a192117af6c3659890a850dd951995620c30f5eaffd +size 210065 diff --git a/tests/cases/fsi/pipe_3d_trilinos_ml/result_005.vtu b/tests/cases/fsi/pipe_3d_trilinos_ml/result_005.vtu index b3c68f1b..40c7adca 100644 --- a/tests/cases/fsi/pipe_3d_trilinos_ml/result_005.vtu +++ b/tests/cases/fsi/pipe_3d_trilinos_ml/result_005.vtu @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:2c5e0a10e6c3f30addeb8595c27f531146fdf22e7d00e132c2b5b6cd01adfd89 -size 208368 +oid sha256:ceccd8ba7067b8b894ae6a192117af6c3659890a850dd951995620c30f5eaffd +size 210065 diff --git a/tests/cases/struct/LV_Guccione_passive/result_001.vtu b/tests/cases/struct/LV_Guccione_passive/result_001.vtu index 2310e805..e545423e 100644 --- a/tests/cases/struct/LV_Guccione_passive/result_001.vtu +++ b/tests/cases/struct/LV_Guccione_passive/result_001.vtu @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:7a9bc73226e027a050e019da4069980bfd0406146b9f499e316c89156fa2f9a0 -size 71061 +oid sha256:482ee113c6a69ea07d4013b454d2bdc320b9138a79cc534b7f96ac24e8ec80bb +size 71554 diff --git a/tests/cases/struct/LV_Holzapfel_passive/result_001.vtu b/tests/cases/struct/LV_Holzapfel_passive/result_001.vtu index b77c5715..3988c33f 100644 --- a/tests/cases/struct/LV_Holzapfel_passive/result_001.vtu +++ b/tests/cases/struct/LV_Holzapfel_passive/result_001.vtu @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:4b6a02ee0e6f576026a76fccd18a887dd675dc699cdf526f50366807c9b883cc -size 248789 +oid sha256:5480109844a69127597cf1ea8b16d6374e0b0fea5b6de06d1a17074df4dc0453 +size 249954 diff --git a/tests/cases/struct/LV_Holzapfel_passive/svFSIplus.xml b/tests/cases/struct/LV_Holzapfel_passive/svFSIplus.xml index d3d7007c..88e6694d 100644 --- a/tests/cases/struct/LV_Holzapfel_passive/svFSIplus.xml +++ b/tests/cases/struct/LV_Holzapfel_passive/svFSIplus.xml @@ -58,9 +58,6 @@ 1.0 1.0e6 0.483333 - - 0.0 - 590.0 diff --git a/tests/cases/struct/LV_NeoHookean_passive/result_005.vtu b/tests/cases/struct/LV_NeoHookean_passive/result_005.vtu index e01aa6d8..c40de81e 100644 --- a/tests/cases/struct/LV_NeoHookean_passive/result_005.vtu +++ b/tests/cases/struct/LV_NeoHookean_passive/result_005.vtu @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:3ecec14df7ebec99b5267e4f6bc97fff8e86b4cd7d897430c12c61e79bceb86f -size 248941 +oid sha256:dd922c75556517e91e3ea8fee3f22a86fca6d3c01b65345b667feea0cf97ba2e +size 248993 diff --git a/tests/cases/struct/LV_NeoHookean_passive/svFSIplus.xml b/tests/cases/struct/LV_NeoHookean_passive/svFSIplus.xml index 529b4c10..7086ae20 100644 --- a/tests/cases/struct/LV_NeoHookean_passive/svFSIplus.xml +++ b/tests/cases/struct/LV_NeoHookean_passive/svFSIplus.xml @@ -59,9 +59,6 @@ ST91 - - 0.0 - diff --git a/tests/cases/struct/LV_NeoHookean_passive_genBC/result_003.vtu b/tests/cases/struct/LV_NeoHookean_passive_genBC/result_003.vtu index 96062588..8e561c34 100644 --- a/tests/cases/struct/LV_NeoHookean_passive_genBC/result_003.vtu +++ b/tests/cases/struct/LV_NeoHookean_passive_genBC/result_003.vtu @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:3e7afe2fc92e79c64d89de3aaecdd55a2c2f05b052321e2276a059b4d9c50ba1 -size 248337 +oid sha256:754e5eafbce51ce6f9c07061664738befea13c9573f2c2de60753c3cc8059bc9 +size 248325 diff --git a/tests/cases/struct/LV_NeoHookean_passive_genBC/svFSIplus.xml b/tests/cases/struct/LV_NeoHookean_passive_genBC/svFSIplus.xml index 4ce3b646..40a90c1c 100644 --- a/tests/cases/struct/LV_NeoHookean_passive_genBC/svFSIplus.xml +++ b/tests/cases/struct/LV_NeoHookean_passive_genBC/svFSIplus.xml @@ -59,9 +59,6 @@ ST91 - - 0.0 - diff --git a/tests/cases/struct/LV_NeoHookean_passive_sv0D/result_003.vtu b/tests/cases/struct/LV_NeoHookean_passive_sv0D/result_003.vtu index 8ef58014..f74606ca 100644 --- a/tests/cases/struct/LV_NeoHookean_passive_sv0D/result_003.vtu +++ b/tests/cases/struct/LV_NeoHookean_passive_sv0D/result_003.vtu @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:6815344539ccdb79eac642845b60f9746d5cb5a0c70ccd0c079d4323405d31dc -size 248341 +oid sha256:7d6e4557acc27f42f7048f4852b369a12a2b87e15b70d618b74663dac63245b7 +size 248293 diff --git a/tests/cases/struct/LV_NeoHookean_passive_sv0D/svFSIplus.xml b/tests/cases/struct/LV_NeoHookean_passive_sv0D/svFSIplus.xml index d8e48dbc..83d62a8e 100644 --- a/tests/cases/struct/LV_NeoHookean_passive_sv0D/svFSIplus.xml +++ b/tests/cases/struct/LV_NeoHookean_passive_sv0D/svFSIplus.xml @@ -59,9 +59,6 @@ ST91 - - 0.0 - diff --git a/tests/cases/struct/block_compression/result_001.vtu b/tests/cases/struct/block_compression/result_001.vtu index e05289c3..ed1a5b9f 100644 --- a/tests/cases/struct/block_compression/result_001.vtu +++ b/tests/cases/struct/block_compression/result_001.vtu @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:5ee431cb36758c667c763044a5ded01b7ac080066e5995faf42f9bffe5d66d20 -size 74449 +oid sha256:b1bbb1fdd5ee8b3bc219befecd0f9f3604a86c9c9372cb008fa13af7e0cf36fd +size 75102 diff --git a/tests/cases/struct/robin/result_001.vtu b/tests/cases/struct/robin/result_001.vtu index ff4f6d57..a7d5e0d1 100644 --- a/tests/cases/struct/robin/result_001.vtu +++ b/tests/cases/struct/robin/result_001.vtu @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:556dc8277bfbcd339d5524759057ebdfb4cd530fc5d03e9cbef9f6feb2b3ae27 -size 12681 +oid sha256:2eb33af9513f681e820423cd0f1d47bb09f8d16f64afae96d0e8a12727a5eeec +size 13170 diff --git a/tests/cases/struct/tensile_adventitia_Guccione_active/result_002.vtu b/tests/cases/struct/tensile_adventitia_Guccione_active/result_002.vtu index 9014f840..99e84d02 100644 --- a/tests/cases/struct/tensile_adventitia_Guccione_active/result_002.vtu +++ b/tests/cases/struct/tensile_adventitia_Guccione_active/result_002.vtu @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:e052cf91294f76d78b06a6a84de84570cd48f9bf951e14ba5297ec8f96b18dfe -size 76313 +oid sha256:dc6629a355444e5648a9895bd28a678e936e21f2c33530bd9c566646071069af +size 76834 diff --git a/tests/cases/ustruct/LV_Guccione_active/result_001.vtu b/tests/cases/ustruct/LV_Guccione_active/result_001.vtu index 6a022183..9e505f64 100644 --- a/tests/cases/ustruct/LV_Guccione_active/result_001.vtu +++ b/tests/cases/ustruct/LV_Guccione_active/result_001.vtu @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:9a063d96839c465428d82ffc4638c16feb3a33d9ee49422353b5f300f5b79479 -size 45994 +oid sha256:fe16ff23fdb103812f0f96f7e3c9c4eeb90d783c5994dc0a7017cada9128f23c +size 72290 diff --git a/tests/cases/ustruct/LV_NeoHookean_passive_genBC/result_003.vtu b/tests/cases/ustruct/LV_NeoHookean_passive_genBC/result_003.vtu index 23e80e4c..ced019ab 100644 --- a/tests/cases/ustruct/LV_NeoHookean_passive_genBC/result_003.vtu +++ b/tests/cases/ustruct/LV_NeoHookean_passive_genBC/result_003.vtu @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:8cfd6cb09faaa2b69537f9e3c08c3bc47cafa8cf2557f04c0518b1daf3067e9d -size 254881 +oid sha256:aaa83f25721074517e0b99122e8a46cb2cd20c6b07ff8232005250b034d6e990 +size 254813 diff --git a/tests/cases/ustruct/LV_NeoHookean_passive_genBC/svFSIplus.xml b/tests/cases/ustruct/LV_NeoHookean_passive_genBC/svFSIplus.xml index ec7758a8..acf1c06c 100644 --- a/tests/cases/ustruct/LV_NeoHookean_passive_genBC/svFSIplus.xml +++ b/tests/cases/ustruct/LV_NeoHookean_passive_genBC/svFSIplus.xml @@ -59,9 +59,6 @@ ST91 - - 0.0 - diff --git a/tests/cases/ustruct/LV_NeoHookean_passive_sv0D/result_003.vtu b/tests/cases/ustruct/LV_NeoHookean_passive_sv0D/result_003.vtu index e58769b0..5f1a9e10 100644 --- a/tests/cases/ustruct/LV_NeoHookean_passive_sv0D/result_003.vtu +++ b/tests/cases/ustruct/LV_NeoHookean_passive_sv0D/result_003.vtu @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:457b22d25ec04e8fd40b6647fc46c310ab5726d4607f7e84db746a4e8a99bf81 -size 254865 +oid sha256:fb12f1c216ab10f389c084f365b168a65100d14df4b6928265b0ecd4716273b6 +size 254837 diff --git a/tests/cases/ustruct/LV_NeoHookean_passive_sv0D/svFSIplus.xml b/tests/cases/ustruct/LV_NeoHookean_passive_sv0D/svFSIplus.xml index 223fc1f7..fc375b06 100644 --- a/tests/cases/ustruct/LV_NeoHookean_passive_sv0D/svFSIplus.xml +++ b/tests/cases/ustruct/LV_NeoHookean_passive_sv0D/svFSIplus.xml @@ -59,9 +59,6 @@ ST91 - - 0.0 - diff --git a/tests/cases/ustruct/block_compression/P1P1_VMS/result_001.vtu b/tests/cases/ustruct/block_compression/P1P1_VMS/result_001.vtu index 9827da8e..042d0449 100644 --- a/tests/cases/ustruct/block_compression/P1P1_VMS/result_001.vtu +++ b/tests/cases/ustruct/block_compression/P1P1_VMS/result_001.vtu @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:d73ebe990ea5f6b87f5bf3ab762a9e0505f238bb79feb77c304ea548ad49a1fa -size 134943 +oid sha256:79d24b0604e405188c2e76ec1c2749db9c4f6b64c4e5730a8a1e79a1f642a5cc +size 135916 diff --git a/tests/cases/ustruct/tensile_adventitia_HGO/result_001.vtu b/tests/cases/ustruct/tensile_adventitia_HGO/result_001.vtu index b95727c8..8fc5cb2e 100644 --- a/tests/cases/ustruct/tensile_adventitia_HGO/result_001.vtu +++ b/tests/cases/ustruct/tensile_adventitia_HGO/result_001.vtu @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:71c2d49517cc87ecec317e68c5bb93e2cb8dd8f393dd0f49ec2cc9b26dee67d9 -size 78259 +oid sha256:93800d0bb952fd4d4c611eeabd2a23d8cec2f3f7fc6efb92d920f936d2e95061 +size 78456