From aca9a10dc5dce2614355ce5b8a755c2eaaa13a37 Mon Sep 17 00:00:00 2001
From: Aaron Brown <71424733+aabrown100-git@users.noreply.github.com>
Date: Thu, 26 Sep 2024 10:28:27 -0700
Subject: [PATCH] Solid viscosity default value bug (#270)
* Change solid_viscosity default value to 0.0
* Update test case reference results, remove Viscosity in some xml files (which sets the fluid viscosity parameter and therefore has no effect)
---
Code/Source/svFSI/Parameters.cpp | 2 +-
tests/cases/fsi/pipe_3d/result_005.vtu | 4 ++--
tests/cases/fsi/pipe_3d_petsc/result_005.vtu | 4 ++--
tests/cases/fsi/pipe_3d_trilinos_bj/result_005.vtu | 4 ++--
tests/cases/fsi/pipe_3d_trilinos_ml/result_005.vtu | 4 ++--
tests/cases/struct/LV_Guccione_passive/result_001.vtu | 4 ++--
tests/cases/struct/LV_Holzapfel_passive/result_001.vtu | 4 ++--
tests/cases/struct/LV_Holzapfel_passive/svFSIplus.xml | 3 ---
tests/cases/struct/LV_NeoHookean_passive/result_005.vtu | 4 ++--
tests/cases/struct/LV_NeoHookean_passive/svFSIplus.xml | 3 ---
tests/cases/struct/LV_NeoHookean_passive_genBC/result_003.vtu | 4 ++--
tests/cases/struct/LV_NeoHookean_passive_genBC/svFSIplus.xml | 3 ---
tests/cases/struct/LV_NeoHookean_passive_sv0D/result_003.vtu | 4 ++--
tests/cases/struct/LV_NeoHookean_passive_sv0D/svFSIplus.xml | 3 ---
tests/cases/struct/block_compression/result_001.vtu | 4 ++--
tests/cases/struct/robin/result_001.vtu | 4 ++--
.../struct/tensile_adventitia_Guccione_active/result_002.vtu | 4 ++--
tests/cases/ustruct/LV_Guccione_active/result_001.vtu | 4 ++--
.../cases/ustruct/LV_NeoHookean_passive_genBC/result_003.vtu | 4 ++--
tests/cases/ustruct/LV_NeoHookean_passive_genBC/svFSIplus.xml | 3 ---
tests/cases/ustruct/LV_NeoHookean_passive_sv0D/result_003.vtu | 4 ++--
tests/cases/ustruct/LV_NeoHookean_passive_sv0D/svFSIplus.xml | 3 ---
tests/cases/ustruct/block_compression/P1P1_VMS/result_001.vtu | 4 ++--
tests/cases/ustruct/tensile_adventitia_HGO/result_001.vtu | 4 ++--
24 files changed, 35 insertions(+), 53 deletions(-)
diff --git a/Code/Source/svFSI/Parameters.cpp b/Code/Source/svFSI/Parameters.cpp
index 95ccb340..72afc07d 100644
--- a/Code/Source/svFSI/Parameters.cpp
+++ b/Code/Source/svFSI/Parameters.cpp
@@ -1299,7 +1299,7 @@ DomainParameters::DomainParameters()
set_parameter("Relative_tolerance", 1e-4, !required, relative_tolerance);
set_parameter("Shell_thickness", 0.0, !required, shell_thickness);
set_parameter("Solid_density", 0.5, !required, solid_density);
- set_parameter("Solid_viscosity", 0.9, !required, solid_viscosity);
+ set_parameter("Solid_viscosity", 0.0, !required, solid_viscosity);
set_parameter("Source_term", 0.0, !required, source_term);
set_parameter("Time_step_for_integration", 0.0, !required, time_step_for_integration);
}
diff --git a/tests/cases/fsi/pipe_3d/result_005.vtu b/tests/cases/fsi/pipe_3d/result_005.vtu
index b3c68f1b..40c7adca 100644
--- a/tests/cases/fsi/pipe_3d/result_005.vtu
+++ b/tests/cases/fsi/pipe_3d/result_005.vtu
@@ -1,3 +1,3 @@
version https://git-lfs.github.com/spec/v1
-oid sha256:2c5e0a10e6c3f30addeb8595c27f531146fdf22e7d00e132c2b5b6cd01adfd89
-size 208368
+oid sha256:ceccd8ba7067b8b894ae6a192117af6c3659890a850dd951995620c30f5eaffd
+size 210065
diff --git a/tests/cases/fsi/pipe_3d_petsc/result_005.vtu b/tests/cases/fsi/pipe_3d_petsc/result_005.vtu
index b3c68f1b..40c7adca 100644
--- a/tests/cases/fsi/pipe_3d_petsc/result_005.vtu
+++ b/tests/cases/fsi/pipe_3d_petsc/result_005.vtu
@@ -1,3 +1,3 @@
version https://git-lfs.github.com/spec/v1
-oid sha256:2c5e0a10e6c3f30addeb8595c27f531146fdf22e7d00e132c2b5b6cd01adfd89
-size 208368
+oid sha256:ceccd8ba7067b8b894ae6a192117af6c3659890a850dd951995620c30f5eaffd
+size 210065
diff --git a/tests/cases/fsi/pipe_3d_trilinos_bj/result_005.vtu b/tests/cases/fsi/pipe_3d_trilinos_bj/result_005.vtu
index b3c68f1b..40c7adca 100644
--- a/tests/cases/fsi/pipe_3d_trilinos_bj/result_005.vtu
+++ b/tests/cases/fsi/pipe_3d_trilinos_bj/result_005.vtu
@@ -1,3 +1,3 @@
version https://git-lfs.github.com/spec/v1
-oid sha256:2c5e0a10e6c3f30addeb8595c27f531146fdf22e7d00e132c2b5b6cd01adfd89
-size 208368
+oid sha256:ceccd8ba7067b8b894ae6a192117af6c3659890a850dd951995620c30f5eaffd
+size 210065
diff --git a/tests/cases/fsi/pipe_3d_trilinos_ml/result_005.vtu b/tests/cases/fsi/pipe_3d_trilinos_ml/result_005.vtu
index b3c68f1b..40c7adca 100644
--- a/tests/cases/fsi/pipe_3d_trilinos_ml/result_005.vtu
+++ b/tests/cases/fsi/pipe_3d_trilinos_ml/result_005.vtu
@@ -1,3 +1,3 @@
version https://git-lfs.github.com/spec/v1
-oid sha256:2c5e0a10e6c3f30addeb8595c27f531146fdf22e7d00e132c2b5b6cd01adfd89
-size 208368
+oid sha256:ceccd8ba7067b8b894ae6a192117af6c3659890a850dd951995620c30f5eaffd
+size 210065
diff --git a/tests/cases/struct/LV_Guccione_passive/result_001.vtu b/tests/cases/struct/LV_Guccione_passive/result_001.vtu
index 2310e805..e545423e 100644
--- a/tests/cases/struct/LV_Guccione_passive/result_001.vtu
+++ b/tests/cases/struct/LV_Guccione_passive/result_001.vtu
@@ -1,3 +1,3 @@
version https://git-lfs.github.com/spec/v1
-oid sha256:7a9bc73226e027a050e019da4069980bfd0406146b9f499e316c89156fa2f9a0
-size 71061
+oid sha256:482ee113c6a69ea07d4013b454d2bdc320b9138a79cc534b7f96ac24e8ec80bb
+size 71554
diff --git a/tests/cases/struct/LV_Holzapfel_passive/result_001.vtu b/tests/cases/struct/LV_Holzapfel_passive/result_001.vtu
index b77c5715..3988c33f 100644
--- a/tests/cases/struct/LV_Holzapfel_passive/result_001.vtu
+++ b/tests/cases/struct/LV_Holzapfel_passive/result_001.vtu
@@ -1,3 +1,3 @@
version https://git-lfs.github.com/spec/v1
-oid sha256:4b6a02ee0e6f576026a76fccd18a887dd675dc699cdf526f50366807c9b883cc
-size 248789
+oid sha256:5480109844a69127597cf1ea8b16d6374e0b0fea5b6de06d1a17074df4dc0453
+size 249954
diff --git a/tests/cases/struct/LV_Holzapfel_passive/svFSIplus.xml b/tests/cases/struct/LV_Holzapfel_passive/svFSIplus.xml
index d3d7007c..88e6694d 100644
--- a/tests/cases/struct/LV_Holzapfel_passive/svFSIplus.xml
+++ b/tests/cases/struct/LV_Holzapfel_passive/svFSIplus.xml
@@ -58,9 +58,6 @@
1.0
1.0e6
0.483333
-
- 0.0
-
590.0
diff --git a/tests/cases/struct/LV_NeoHookean_passive/result_005.vtu b/tests/cases/struct/LV_NeoHookean_passive/result_005.vtu
index e01aa6d8..c40de81e 100644
--- a/tests/cases/struct/LV_NeoHookean_passive/result_005.vtu
+++ b/tests/cases/struct/LV_NeoHookean_passive/result_005.vtu
@@ -1,3 +1,3 @@
version https://git-lfs.github.com/spec/v1
-oid sha256:3ecec14df7ebec99b5267e4f6bc97fff8e86b4cd7d897430c12c61e79bceb86f
-size 248941
+oid sha256:dd922c75556517e91e3ea8fee3f22a86fca6d3c01b65345b667feea0cf97ba2e
+size 248993
diff --git a/tests/cases/struct/LV_NeoHookean_passive/svFSIplus.xml b/tests/cases/struct/LV_NeoHookean_passive/svFSIplus.xml
index 529b4c10..7086ae20 100644
--- a/tests/cases/struct/LV_NeoHookean_passive/svFSIplus.xml
+++ b/tests/cases/struct/LV_NeoHookean_passive/svFSIplus.xml
@@ -59,9 +59,6 @@
ST91
-
- 0.0
-