Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remeshing node interpolation does not always find the correct element #105

Open
ktbolt opened this issue May 6, 2023 · 1 comment
Open
Assignees
Labels
bug Something isn't working

Comments

@ktbolt
Copy link
Contributor

ktbolt commented May 6, 2023

When remeshing the FINDN subroutine in the REMESH.f file is used to find the element in the old mesh for each node in the new mesh. This is used to interpolated the last solution to the new mesh.

When comparing the Fortran remeshing code results with the converted C++ code I've noticed that FINDN does not always return the element the node is actually contained in.

FINDN calls the MAT_INV function which in turn calls the MAT_INV_GE function to compute the inverse of a 4x4 matrix used to find the local element coordinates for a given node.

The problem is that MAT_INV_GE does not always compute the correct inverse matrix. The inverse matrix can in fact sometimes contain NaNs.

@ktbolt ktbolt added the bug Something isn't working label May 6, 2023
@ktbolt ktbolt self-assigned this May 6, 2023
@ktbolt
Copy link
Contributor Author

ktbolt commented May 6, 2023

For svFSIplus I reimplemented the MAT_INV_GE function to compute a better pivot element I think and now the correct element is always found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant