Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add svFSIplus documentation #19

Open
1 task done
ktbolt opened this issue Apr 23, 2024 · 17 comments
Open
1 task done

Add svFSIplus documentation #19

ktbolt opened this issue Apr 23, 2024 · 17 comments
Assignees
Labels
enhancement New feature or request

Comments

@ktbolt
Copy link
Contributor

ktbolt commented Apr 23, 2024

Use Case

It would be helpful to users to have documentation describing how to use svFSIplus.

Problem

There is no svFSIplus documentation.

Solution

Write svFSIplus documentation.

Alternatives considered

Don't write svFSIplus documentation.

Additional context

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct and Contributing Guidelines
@ktbolt ktbolt added the enhancement New feature or request label Apr 23, 2024
@ktbolt ktbolt self-assigned this May 11, 2024
@ktbolt
Copy link
Contributor Author

ktbolt commented May 11, 2024

I am going to start on this.

@alisonmarsden Should I remove the svFSI documentation?

@alisonmarsden
Copy link

alisonmarsden commented May 13, 2024 via email

@ktbolt
Copy link
Contributor Author

ktbolt commented May 31, 2024

I've taken the svFSI docs and reorganized them for svFSIplus, not sure of the final format yet.
Screenshot 2024-05-30 at 8 46 35 PM

@ktbolt
Copy link
Contributor Author

ktbolt commented May 31, 2024

I am also experimenting with documenting the solver input XML file by showing the XML element name, type and a link (blue) to the parameter definition.

Screenshot 2024-05-30 at 9 21 06 PM

@ktbolt
Copy link
Contributor Author

ktbolt commented Jun 20, 2024

I've added more solver input XML file documentation: mesh, equation, linear solver and boundary condition parameters
Screenshot 2024-06-19 at 7 49 42 PM

I am currently documenting parameters in two sections

  1. XML format
Screenshot 2024-06-19 at 7 53 28 PM
  1. Description
Screenshot 2024-06-19 at 7 53 43 PM

clicking on the blue XML format moves the page to that parameter's description.

I thought this would help show the XML structure better because it can have nested sections.
Screenshot 2024-06-19 at 8 02 23 PM

But maybe having the XML format and description together would be better.

@ktbolt
Copy link
Contributor Author

ktbolt commented Jun 22, 2024

I've changed the parameter format to have the XML format and description together

Screenshot 2024-06-21 at 6 54 02 PM

This is super tedious to write but I think it works better.

@ktbolt
Copy link
Contributor Author

ktbolt commented Jun 29, 2024

I've mostly finished the XML parameter documentation, still a bunch of parameters that are not documented, no definitions in the svFSI svFSI_master.inp file.

@ktbolt
Copy link
Contributor Author

ktbolt commented Jul 3, 2024

I'm now writing a Running svFSI section to explain element types and node ordering, VTK mesh files, BC data files formats, etc.

@ktbolt
Copy link
Contributor Author

ktbolt commented Jul 13, 2024

I've added most of the FSI Tool documentation, still need to add some of the parameter descriptions though.
Screenshot 2024-07-12 at 6 57 18 PM

@ktbolt
Copy link
Contributor Author

ktbolt commented Jul 18, 2024

I've added a Tutorial for setting up a fluids simulation.
Screenshot 2024-07-18 at 11 55 50 AM

@ktbolt
Copy link
Contributor Author

ktbolt commented Jul 19, 2024

I've added a rough User Guide section taking material from the svFSI documentation
Screenshot 2024-07-18 at 6 24 29 PM

This section is going to require a lot more work.

@ktbolt
Copy link
Contributor Author

ktbolt commented Jul 25, 2024

I've now added a Data File Format section documenting the formats of

  • Text files used for boundary conditions and domain IDs
  • VTK files for mesh, initial conditions and boundary conditions
Screenshot 2024-07-24 at 6 23 47 PM

@ktbolt
Copy link
Contributor Author

ktbolt commented Aug 2, 2024

I'm now adding a bit of Developer Guide documentation.
Screenshot 2024-08-01 at 6 52 01 PM

@ktbolt
Copy link
Contributor Author

ktbolt commented Aug 3, 2024

I've added a Code Organization section documenting the organization of the files and such.
Screenshot 2024-08-02 at 5 36 36 PM

@ktbolt
Copy link
Contributor Author

ktbolt commented Aug 9, 2024

I've added an Implementation Details section which covers some useful details of the well, implementation
imp-details

In the Flow of Control section I outline the calling sequence and such of the program
flow

and

iterate

@ktbolt
Copy link
Contributor Author

ktbolt commented Aug 12, 2024

I've added Linear Algebra Interface

Screenshot 2024-08-12 at 2 35 47 PM

and VTK Interface implementation sections

Screenshot 2024-08-12 at 2 38 57 PM

@ktbolt
Copy link
Contributor Author

ktbolt commented Aug 14, 2024

@MatteoSalvador @aabrown100-git @mrp089 @menon-karthik @dcodoni @zasexton @kharold23 @elenasmartinez @lpapamanolis @msbazzi I've finished all that I can do for the documentation.

I now need people to

  • check for errors
  • suggest any rewrite/reorganization
  • add docs for xml parameters that I couldn't explain, especially for electrophysiology
  • write a theory section
  • rewrite the User Guide sections; these were take from the svFSI docs

Clone the https://github.com/ktbolt/simvascular.github.io/tree/Add-svFSIplus-documentation_19 branch and have a look.

I use caddy to view the web pages

  • install
  • cd to simvascular.github.io
  • run caddy file-server --listen localhost:2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants