Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise Enhancements up to the level of the prompts #226

Conversation

ntindle
Copy link
Member

@ntindle ntindle commented Apr 19, 2024

Raise error messages to the prompt

Copy link

linear bot commented Apr 19, 2024

AGPT-695

@ntindle ntindle marked this pull request as ready for review April 22, 2024 22:29
@ntindle ntindle requested review from Torantulino, Swiftyos and majdyz and removed request for Torantulino April 22, 2024 22:29
@Swiftyos
Copy link
Contributor

It would probably be a good idea to start measuring the impact of our changes before merging them in.

I suspect we want to be trying to minimise the length of our prompts as much as possible

@Torantulino
Copy link
Member

Torantulino commented Apr 23, 2024

This should be a great change, but we have to be careful that this doesn't flood the prompt with knock-on error messages and hide the real error which is causing the issue.

How have you found the success rate of this vs the existing error enhancements?

Curious to see some prompts this has constructed.

@ntindle
Copy link
Member Author

ntindle commented Apr 23, 2024

/benchmark

@Torantulino
Copy link
Member

I suspect we want to be trying to minimise the length of our prompts as much as possible

We certainly want to keep prompts small to avoid the "needle in the haystack" problem, and general degradation of performance that comes with long prompts.

However inserting errors with small documentation snippets like this should in theory be a great use of that token budget in my opinion.

@Torantulino Torantulino merged commit dfa0f3a into main Apr 23, 2024
3 checks passed
@Torantulino Torantulino deleted the ntindle/agpt-695-raise-the-error-enhancements-up-to-the-level-of-the-prompt branch April 23, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants