-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Batch edit #1268
Comments
I'm working on the BatchEditForm now. (At the moment, new senses cannot be created, and senses cannot be reordered. Gloss Edit will need to be used for that. Otherwise too much interface code is needed.) |
@uklomp do all glosses have senses? If the gloss does not have senses, do you want an empty field to appear? To avoid yet another method to create senses if possible? At the moment, there is Gloss Edit, Keywords Mapping Edit (this is also batch edit but just for senses), and API create gloss, and API update gloss. The Analysis -> Keywords Mapping was meant to facilitate the change from the Keywords system to the Senses system for already existing glosses, since there were only keywords to begin with. These can then be split up into senses. |
I have some of the fields done already. The toggles are implemented and work. The language fields can be edited, but a Save button is needed for these. (Hence my question above. As you can see there are no fields for the senses for this specific gloss -- a copy from NGT to tstMH, the Copy button only copies phonology.) |
The plan is to show videos for similar glosses below when say Handedness, Strong Hand and Weak Hand have been filled in. (Enough fields need to be filled in or there can be thousands, if you only have Handedness filled in.) Sufficient fields need to be available in the Toggles area in order to narrow down the focus. Perhaps a button when you think the gloss phonology is "done" to generate the similar gloss videos? |
Here is what happens with displaying the senses this way. This is one of the test glosses that we used when Senses were being developed. The keywords are split into different senses. (Although as non-signers, we have no idea if this is nonsense.) This looks a bit much. Although this is what it looks like. |
I can make it so the language fields also collapse to hide them. Suggestions are welcome! |
Moved video to same table cell table as gloss affiliation and creator
Not all glosses have senses, I'd like to be able to add them then yes, so a field would be good. |
I'll experiment with that next. I have the phonology fields working as shown above. Just need to keep adding more. The query results has been done so it starts with the query results in the list. I'm working on the language fields now. I'll modify the display to show the languages in columns. Do you want more things in the Language Fields panel? A create button for senses? I'll do the columns next and post a screenshot. |
I remember that we talked about making phonology work this way, but I didn't remember putting them in this BatchEdit as well. I'm not sure yet if it's a benefit, but it's also not a disadvantage I suppose. Senses in two columns: looks way better, thanks. What do you mean with language fields, I have no idea what they are? |
The language fields (what I call them, code wise) are dependent on the translation languages of the dataset. Because batch edit is a giant input area, the form fields have the gloss id attached, the buttons have the id attached,... The phonology is super easy to update this way, no pulldowns. What about calling them "Text Translation Fields" ? It would be possible to just hit Enter after updating some text. But that could go wrong if the user forgets to type enter. The fields will looked changed on the screen after editing the text. But there needs to be a signal to the computer that it is ready to save. (Hence the OK buttons all over the place in Gloss Edit.) The text fields are handled differently because for each text field, there are some other objects attached. |
We talked about having the similar glosses show up while you are entering the phonology. (For glosses that have the phonology filled in already, you can see homonyms and minimal pairs, or use the Query button to search on the glosses's phonology fields.) This would be weird to do in Gloss Edit, since you are in Edit mode and all the cells are red, waiting for input. With Batch Edit, you don't need to keep reloading the page nor go to a different list view. |
add to revision history. Give feedback when update not possible
[NOTE TO SELF SKIP] This is implemented now, except for the senses. There needs to be some kind of indicator so the user will know when the text fields have been updated in the database. With the batch edit form, you type in text and the fields appear changed in the display, but nothing is saved until you hit the save button for the gloss. We could use separate entry fields for the "new" text versus the "gloss" text. Then you would see the fields update. Or I can make it show success feedback or a green checkmark. Django can keep track of the gloss field values. But if you change this in the form, then you need to do something (user needs to click on something) in order for Django to fetch the gloss data for the field again. (When you update the text, you are changing what is on the screen.) I'll try adding a green checkmark after save. Or when the text matches the contents of the gloss. Or a different checkmark if the on-screen text has been changed. (But this cannot be know, because the real values are in the database.) That's probably confusing. This could be solved by putting the "entry text fields" in the panel to the right and not type directly into the fields. Then clicking on save, you would see the fields on the left updated. |
[NOTE TO SELF] There might need to be a clear form button after an unsuccessful attempt to update the text fields. |
@uklomp this is on signbank-test now. UNDER THE ANALYSIS MENU |
One comment here, there are no small videos. The creation of small videos has been broken for a long time. There is a bug in the CNGT scripts. |
The hyperlink annotation shown under the video is updated to show an update to the dataset default annotation. |
Show help message and link to Signs Search.
Fixed typo and retrieval error in annotation constraint checking.
Text Fields panel OPEN on viewing. (User can explicitly close them.) |
Toggle named entitiy and word class added to revision history
For each gloss, there will be a SAVE TEXT button. Updates to the "text fields" of EACH gloss involves updates to the following TABLES / related objects to the gloss:
Additionally, video files may be moved if lemma translations or gloss annotations of one gloss have been updated. |
Hey @uklomp (when you're back), Susan and I disagree about whether there should be 1 generic 'save/apply' button instead of a separate one for each gloss. I don't remember your viewpoint here? Susan does correctly note that if there's only one button, you might get a whole list of objections, similar to what you get when uploading a CSV. |
Fixed hide show of toggle groups per gloss.
BatchEditListView
, where you see each search result as a row, and as columns:BatchEditListView
has only oneApply
button (unlike the detail view, where you have to clickOK
for every change you make)The text was updated successfully, but these errors were encountered: