Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update scroll-bar when default gloss annotation is updated #1248

Open
susanodd opened this issue May 23, 2024 · 1 comment
Open

Update scroll-bar when default gloss annotation is updated #1248

susanodd opened this issue May 23, 2024 · 1 comment
Assignees

Comments

@susanodd
Copy link
Collaborator

susanodd commented May 23, 2024

The scroll bar needs to be regenerated once any of the glosses have had the annotations updated in the API.
The scroll bar is only "computed" and is a list of hyperlinks. At the moment, this is only generated again once a new query is done. Otherwise all the "gloss annotations" are encapsulated in it.

This mismatch will only happen if you're actually using Signbank at the same time as things are being updated by calls to the API.
Because the scrollbar is a session variable, it does not update the strings until another query has been done. (By yourself.) So this could be weird for users actually using Signbank while there are API things going on.

@susanodd susanodd changed the title Update scroll-bar gloss annotations when API updates them Update scroll-bar when default gloss annotation is updated Jul 2, 2024
susanodd added a commit that referenced this issue Jul 2, 2024
@susanodd susanodd self-assigned this Jul 17, 2024
@susanodd
Copy link
Collaborator Author

I made this happen in a few places in the new views.

The normal update inside of Gloss Edit does not do this yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant