-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Signbank API: When updating senses, the update is not reflected in last_timestamp #1239
Comments
This is probably because senses are comprised of many relation objects and not a gloss field. This only happens when you have only updated the Senses and no other fields, right? Probably the query on Gloss objects needs to be unioned with GlossSense objects. Does it work correctly if you set the time interval to something longer than 5 minutes? @Jetske can you think about this? You are deleting the old senses and making new ones when updating, is that correct? |
I looked at some of the recently created glosses on NGT. https://signbank.cls.ru.nl/dictionary/gloss/48084/history |
The change should be reflected as we look to timestamp now - 5 minutes, so when i change the sense the glos doesnt show up in the glosses JSON file. When phonological information is updated it does. I have tested with this one: https://signbank.cls.ru.nl/dictionary/gloss/47350/. I do see senses update in the query but nothing in JSON. |
Okay, thanks! I will try to make it show up using the approaches mentioned above. The query that looks at the timestamp uses the Gloss field lastUpdated. Senses do not have this field. It is updated whenever a gloss object is saved. |
I'm looking at the code where things are saved. But the code is already doing a gloss.save after it updates the senses. I revised this to update the field explicitly. (But updating the senses does not work for me at all. There's a different bug saving the senses to the revision history. It looks like the |
#1239: Explicitly save timestamp when senses are updated.
This has been deployed. As far as I can tell, this works now. |
We are running updater every 5 minutes and based on since_timestamp -5 minutes we retrieve a json file. And i noticed there is no change reflected in the json file when we update senses on signbank, other changes like phonology are fine.
The text was updated successfully, but these errors were encountered: