diff --git a/signbank/dictionary/adminviews.py b/signbank/dictionary/adminviews.py index 74c91d33..7c91c463 100755 --- a/signbank/dictionary/adminviews.py +++ b/signbank/dictionary/adminviews.py @@ -6531,14 +6531,23 @@ def get_context_data(self, **kwargs): context['available_semanticfields'] = [semfield for semfield in SemanticField.objects.filter( machine_value__gt=1).order_by('name')] - context['available_handedness'] = [h for h in FieldChoice.objects.filter( + available_handedness = [fc for fc in FieldChoice.objects.filter( + field='Handedness', machine_value__in=[0, 1]).order_by('machine_value')] + available_handedness += [fc for fc in FieldChoice.objects.filter( field='Handedness', machine_value__gt=1).order_by('name')] + context['available_handedness'] = available_handedness - context['available_handshape'] = [wc for wc in Handshape.objects.filter( + available_handshape = [hs for hs in Handshape.objects.filter( + machine_value__in=[0, 1]).order_by('machine_value')] + available_handshape += [hs for hs in Handshape.objects.filter( machine_value__gt=1).order_by('name')] + context['available_handshape'] = available_handshape - context['available_locprim'] = [h for h in FieldChoice.objects.filter( + available_locprim = [fc for fc in FieldChoice.objects.filter( + field='Location', machine_value__in=[0, 1]).order_by('machine_value')] + available_locprim += [fc for fc in FieldChoice.objects.filter( field='Location', machine_value__gt=1).order_by('name')] + context['available_locprim'] = available_locprim # data structures to store the query parameters in order to keep them in the form context['query_parameters'] = json.dumps(self.query_parameters) diff --git a/signbank/dictionary/batch_edit.py b/signbank/dictionary/batch_edit.py index d130c8ab..e7f2ec7f 100644 --- a/signbank/dictionary/batch_edit.py +++ b/signbank/dictionary/batch_edit.py @@ -16,7 +16,6 @@ def internal_batch_update_fields_for_gloss(gloss): languages = gloss.lemma.dataset.translation_languages gloss_prefix = str(gloss.id) + '_' - gloss_suffix = '_' + str(gloss.id) internal_batch_fields = [] for language in languages: gloss_lemma_field_name = BatchEditForm.gloss_lemma_field_prefix + gloss_prefix + language.language_code_2char @@ -27,13 +26,9 @@ def internal_batch_update_fields_for_gloss(gloss): internal_batch_fields.append(gloss_annotation_field_name) for language in languages: - gloss_sense_field_name = self.gloss_sense_field_prefix + gloss_prefix + language.language_code_2char + gloss_sense_field_name = BatchEditForm.gloss_sense_field_prefix + gloss_prefix + language.language_code_2char internal_batch_fields.append(gloss_sense_field_name) - internal_batch_fields.append('handedness' + gloss_suffix) - internal_batch_fields.append('domhndsh' + gloss_suffix) - internal_batch_fields.append('subhndsh' + gloss_suffix) - return internal_batch_fields @@ -60,6 +55,17 @@ def get_sense_numbers(gloss): return senses_mapping +def add_gloss_update_to_revision_history(user, gloss, field, oldvalue, newvalue): + + revision = GlossRevision(old_value=oldvalue, + new_value=newvalue, + field_name=field, + gloss=gloss, + user=user, + time=datetime.now(tz=get_current_timezone())) + revision.save() + + def batch_edit_update_gloss(request, glossid): """Update the gloss fields""" if not request.user.is_authenticated: diff --git a/signbank/dictionary/templates/dictionary/admin_batch_edit_view.html b/signbank/dictionary/templates/dictionary/admin_batch_edit_view.html index 11aaf658..6abef4c5 100644 --- a/signbank/dictionary/templates/dictionary/admin_batch_edit_view.html +++ b/signbank/dictionary/templates/dictionary/admin_batch_edit_view.html @@ -270,7 +270,6 @@