Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change dataset id naming in ECV export #192

Closed
henrinie opened this issue Oct 5, 2016 · 3 comments
Closed

Change dataset id naming in ECV export #192

henrinie opened this issue Oct 5, 2016 · 3 comments
Labels
major

Comments

@henrinie
Copy link
Member

henrinie commented Oct 5, 2016 •
edited
Loading

Currently the name of the dataset is tied to Elan ECV export. Changing the dataset name might therefore be problematic.
So I think we need to create a new field for datasets, one that will be used as an ID in ELAN. One that can't be edited. We could use the id from the database, but that would limit our options if we ever want to move to another database, the ID's might change then and break the ELAN connectivity.

Also we might want to use this new dataset ID for the elan export's url too.
@henrinie
Copy link
Member Author

henrinie commented Feb 7, 2017 •
edited
Loading

An example of this is the following:
<CONTROLLED_VOCABULARY CV_ID="VKK_FinSL">

Perhaps we should use an id like 'dataset1', which could be composed from 'dataset' + id/pk

Before doing anything, check with annotators! Because I don't know yet what would happen if you change this value.

@henrinie
Copy link
Member Author

Alright, we can just use dataset.id for this instead of the name.
Unsure of the effects to the ELAN files, if we change this. So might not change it and hope that no one changes the dataset name.

@henrinie henrinie changed the title Create a read-only ID for datasets Change dataset id naming in ECV export May 11, 2017
henrinie added a commit that referenced this issue May 16, 2017
@henrinie
#192 CHANGED DATASET NAMING IN ECV FILES! You need to modify your ELA…
c7282e3 
…N files (.eaf) manually to accomodate these changes, make sure you backup those files before editing.

- Using 'signbank-dataset-<id>' instead of dataset.name (eg. "VKK_FinSL"), because if someone would change the name of the dataset, it would mess up the ELAN files.
@henrinie henrinie mentioned this issue May 16, 2017
Open
@henrinie
Copy link
Member Author

This has been implemented in c7282e3
Related issue is #241

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
major
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@henrinie