Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Information about tracing models #66

Open
edufschmidt opened this issue Oct 5, 2024 · 6 comments
Open

Information about tracing models #66

edufschmidt opened this issue Oct 5, 2024 · 6 comments

Comments

@edufschmidt
Copy link

edufschmidt commented Oct 5, 2024

Hi @ShunChengWu, I'm trying to trace the models you provide in this repo to use them on ONNX in SceneGraphFusion, but am struggling a bit due to several factors. It seems that a few of the modules the code relies on don't have the necessary trace function implemented. Also, for the models built on pytorch-geometric, it seems that tracing is not supported due to the utilization of pytorch-scatter, which in turn uses functions that don't play well with ONNX. I'm wondering if you could confirm that it is possible and you have traced the models for utilization with SceneGraphFusion. If so, where can I find instructions on how to reproduce that? If not, what do you suggest one should do in order to be able to integrate the provided models with SceneGraphFusion? Thanks in advance!

@edufschmidt
Copy link
Author

Ok, I was able to trace at least one of the models by:

  • upgraded pretty much every module to its latest version;
  • changed the onnx opset (>18) used when exporting;
  • modified the 3DSSG code a bit;
  • monkeypatched pytorch’s min and max operators;

I am now struggling with using the traced model with SceneGraphFusion. Specifically, I couldn't find instructions to generate the args.json SceneGraphFusion seems to rely on. Any help would be much appreciated.

@ShunChengWu
Copy link
Owner

The newer version of this repo is not supported. You will have to use the cvpr21 branch to be compatible with the SceneGraphFusion repo

@edufschmidt
Copy link
Author

Thanks @ShunChengWu for your reply. Does that mean that the only model compatible with SceneGraphFusion is the one available in this link found in the cvpr21 branch? Could you please also confirm that the other models whose weights are available for download here in the main branch are not compatible and have not been tested with SceneGraphFusion? Thanks in advance!

@ShunChengWu
Copy link
Owner

The models trained with the cvpr21 branch are compatible with the SceneGraphFusion repo. The models from the current main branch are not compatible

@edufschmidt
Copy link
Author

Thanks again for your reply. I understand. Are any weights available for the models in the cvpr21 branch or do I have to do the training myself?

@ShunChengWu
Copy link
Owner

The link you mentioned before is the trained and traced model weights. As far as I remember, we didn't provide the typical checkpoint files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants