-
-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add default source that uses is_async #669
Comments
I don't want to add no needed I think is_async source is not so needed in current deoplete. |
Yes.
No.
|
Are you sure? Why not? |
Really? |
I think the pattern of notifying instead of being polled is better, since it causes less overhead. |
If deoplete uses neovim event loop, the implementation may be possible. And it is not compabile with older source implementation. I think async source support is not important. |
It would be useful to have an example or default source that makes use of
is_async
.As for the feature itself it seems like deoplete is polling the sources regardless (until
is_async
gets set toFalse
), right?Would it be possible for the source to call deoplete instead?
Related: I've seen deoplete being stuck in the
completion_begin
/completion_end
loop / polling all the time while in insert mode. This might be related to deoplete-jedi having crashed while experimenting (and therefore never could setself.is_async = False
), but am not sure.This needs investigation.
Ref: wellle/tmux-complete.vim#80
The text was updated successfully, but these errors were encountered: