Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollback system is confusing #851

Open
qq99 opened this issue Dec 4, 2018 · 0 comments
Open

Rollback system is confusing #851

qq99 opened this issue Dec 4, 2018 · 0 comments

Comments

@qq99
Copy link

qq99 commented Dec 4, 2018

Often, we know that e.g. "SHA 599db8 is good" or "SHA 32df81 is bad"

screen shot 2018-12-04 at 11 02 38 am

So I see this, and I think, clicking this button, what will happen? Will I be on 892... or 599... after the operation completes? Then I look to the deploy below, see the same SHA referenced, and have to think some more. In the confusion of an incident, this potential for confusion doesn't help my confidence in picking the right course of action swiftly. Maybe I just don't rollback enough, but I figure that I cannot be the only one.

Main proposal

Given knowledge that "SHA 599db8 is good" or "SHA 32df81 is bad", I think that perhaps it would be more clear if the rollback button said directly instead, Rollback to 599db80428, because to this deploy seems rather obvious and doesn't add much

Secondary proposal

Further, putting the full SHA from git log onto the message somewhere onto the page could help with cmd+f => paste in ba253674eb4831031fbf6131ec19874d80aba975, but I can accept grabbing 8 or so chars from git log and truncating it myself

Thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant