Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

Fail gem signing unless the access token's verified email address appears in the gemspec's list of maintainers #57

Open
rochlefebvre opened this issue Jan 18, 2022 · 0 comments

Comments

@rochlefebvre
Copy link

rochlefebvre commented Jan 18, 2022

We currently allow any verified email address to sign a gem, which means that anyone may sign any gem. At signature verification time, a gem consumer would reasonably only consider signatures from actual maintainers (see #58).

In the future, we may support different kinds of signatures (I build this gem, I reviewed it, I tested it, etc.), and those attestation types would appear as part of the signature (i.e., the Rekor log entry). Since we're only using basic rekords for now, with no additional fields, we can't really qualify signatures.

Let's look at what email was used to authenticate the signer, and reference it against the list of emails in the gemspec. If it's not listed (emails field?), then don't bother acquiring a fulcio certificate.

The two OpenID implementations produce an access token, and this token contains an email field. It may make sense to make this check as part of the GemSigner bit, before we call Fulcio.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant