Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash on iOS version : 1.5.5 #2751

Closed
hamdij0maa opened this issue Nov 20, 2024 · 11 comments · Fixed by #2753
Closed

Crash on iOS version : 1.5.5 #2751

hamdij0maa opened this issue Nov 20, 2024 · 11 comments · Fixed by #2753
Labels

Comments

@hamdij0maa
Copy link

  • updated from 1.5.3 to 1.5.5
  • build on iOS
  • Instant crash

<Canvas mode="default" pointerEvents="none" style={themeStyles.box('absoluteFillObject', 'dark')} collapsable={false}> <Rect x={0} y={0} width={width} height={height}> <LinearGradient positions={positions} start={startVector} end={endVector} colors={colors} /> </Rect> </Canvas>

@wcandillon
Copy link
Contributor

Can you give me more information on how to reproduce the issue?
Helpful things would include:

  • A standalone example
  • Information about the reproduction (release/debug mode, physical device, simulator)
  • The kind of crash that happens

@drookyn
Copy link

drookyn commented Nov 20, 2024

Same on version 1.5.4. Error could be RNSKIA: Could not retrieve drawable from CAMetalLayer. Simulator just freezes.
No problems with 1.5.3 (coming from 1.5.0).

Device: iPhone 15 Pro

@wcandillon
Copy link
Contributor

@drookyn the error seems to make sense based on changes we have made, would you have a standalone example that allow to reproduce the crash?

@hamdij0maa
Copy link
Author

  • Simulator : iPhone 12 Pro
  • rendering LinearGradient:
    <Canvas mode="default" pointerEvents="none" style={themeStyles.box('absoluteFillObject', 'dark')} collapsable={false}>
  • Debug mode

@drookyn
Copy link

drookyn commented Nov 20, 2024

@wcandillon not on the fly. Is hamdij0maa's example enough if its reproducible?

@wcandillon
Copy link
Contributor

@drookyn no we have the example app + e2e test suite that pass, I'd be curious to get a sense of the condition that can create this error.

@hamdij0maa
Copy link
Author

changing the canvas style from :
absoluteFillObject: {
...StyleSheet.absoluteFillObject,
top: 0,
left: 0,
right: 0,
bottom: 0,
},
to :
absoluteFillObject: {
height: SIZES.screenHeight,
width: SIZES.screenWidth,
},

-- height , width if not set => causes the crash

@wcandillon
Copy link
Contributor

Thanks a lot @hamdij0maa I was able to reproduce the crash and now submitting a fix for it.

@hamdij0maa
Copy link
Author

@wcandillon thank you 🙏🏼 🚀

Copy link
Contributor

🎉 This issue has been resolved in version 1.5.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

@hamdij0maa
Copy link
Author

hamdij0maa commented Nov 20, 2024

@wcandillon installed 1.5.6 , instant crash will lyk once issue found, iOS Simulator, version 1.5.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants