You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, Referrer.parse returns type: "invalid" if the netlocation of the referrer URL is a valid IP address. Referrers like this are definitely valid, so in places where Referrer.parse is being used, we have to check for valid IP addresses in the netloc and explicitly set the type to "indirect" instead of "invalid" which isn't ideal.
ref shows a type: "invalid", but if we run IP(parsed_url.netloc) (where IP is from IPy) and see that the IP address is valid and the referrer shouldn't be tagged as "invalid". As a result, we have to explicitly check for this case and overwrite the type to "indirect" when using Referrer.parse().
Currently,
Referrer.parse
returnstype: "invalid"
if the netlocation of the referrer URL is a valid IP address. Referrers like this are definitely valid, so in places whereReferrer.parse
is being used, we have to check for valid IP addresses in the netloc and explicitly set thetype
to"indirect"
instead of"invalid"
which isn't ideal.For example:
ref
shows atype: "invalid"
, but if we runIP(parsed_url.netloc)
(whereIP
is from IPy) and see that the IP address is valid and the referrer shouldn't be tagged as "invalid". As a result, we have to explicitly check for this case and overwrite thetype
to"indirect"
when usingReferrer.parse()
.cc @CamDavidsonPilon
The text was updated successfully, but these errors were encountered: