ResourceList
force an update when items
prop reference change
#7623
Unanswered
pedrodurek
asked this question in
General
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Why do we force an update whenever the
items
prop fromResourceList
change? This forces us to pass a stable reference, otherwise it may cause unnecessary rerenders or/and unwanted behaviour. There are many places acrossShopify/web
where items are not stable because its original value is being formatted (e.g.: usingmap
orfilter
) withoutuseMemo
. For example:or even
That's an issue even for stable references, whenever the reference changes, it'll force the
ResourceList
to rerender twice.Beta Was this translation helpful? Give feedback.
All reactions