Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Json.marshal in Goluago doesn't process arrays #52

Closed
iyaz-shaikh opened this issue Oct 23, 2024 · 1 comment
Closed

Json.marshal in Goluago doesn't process arrays #52

iyaz-shaikh opened this issue Oct 23, 2024 · 1 comment
Assignees
@iyaz-shaikh

Comments

@iyaz-shaikh
Copy link
Member

iyaz-shaikh commented Oct 23, 2024 •
edited
Loading

Currently the json.marshal method in goluago doesn't support tables of arrays. Due to this bug, we have situations in genghis-flows where teams have to construct their own json manually if it has an array in it. See here

We should fix this bug so that teams can use json.marshal for tables with arrays.
@iyaz-shaikh iyaz-shaikh self-assigned this Oct 28, 2024
@iyaz-shaikh
Copy link
Member Author

As it turns out, this isn't actually a bug. We just need to use the array helper to convert lua tables into JSON encoded arrays. I'll fix this in the cart concern as part of a separate PR/issue.

@iyaz-shaikh iyaz-shaikh closed this as not planned Won't fix, can't repro, duplicate, stale Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iyaz-shaikh iyaz-shaikh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@iyaz-shaikh