Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Pulling only (-o) specific folder doesn't work as expected #4855

Open
2 tasks done
aleksandar89d opened this issue Nov 14, 2024 · 2 comments
Open
2 tasks done
Labels
Area: @shopify/theme @shopify/theme package issues Severity: 3 Normal Severity Type: Bug Something isn't working

Comments

@aleksandar89d
Copy link

Please confirm that you have:

  • Searched existing issues to see if your issue is a duplicate. (If you’ve found a duplicate issue, feel free to add additional information in a comment on it.)
  • Reproduced the issue in the latest CLI version.

In which of these areas are you experiencing a problem?

Theme

Expected behavior

When I am using command shopify theme pull -o templates/, it should pull just templates folder and all files inside it.
This works on version 3.59.0.
This is from package json;
"pull-hr": "shopify theme pull -o templates/ sections/*.json config/settings_data.json
It should pull whole templates folder, json files from sections folder and settings_data.json file. And it works on 3.59.0 Cli version.

Actual behavior

On version 3.70.0 it doesn't work as expected.
When I try to pull just specific theme folder, it doens't work.
Localy I don't have templates/ folder and it should create it, everythiing worked fine on earlier versions.
It shows that files are pulled, but folder is not pulled actually.

Verbose output

There is no error, but files simply are not pulled.

Reproduction steps

1.Try to pull just one folder, example shopify theme pull -o templates/

Operating System

Mac OS 14.1

Shopify CLI version (check your project's package.json if you're not sure)

3.70.0

Shell

zsh

Node version (run node -v if you're not sure)

v21.6.2

What language and version are you using in your application?

No response

@aleksandar89d aleksandar89d added the Type: Bug Something isn't working label Nov 14, 2024
@craigmichaelmartin craigmichaelmartin added the Area: @shopify/theme @shopify/theme package issues label Nov 14, 2024
@lucyxiang lucyxiang added the Theme Sev-2 second highest severity for theme related bug label Nov 14, 2024
@lucyxiang
Copy link
Contributor

Thank you for raising this @aleksandar89d. I was able to replicate this issue, I'll put this issue in our backlog.

@lucyxiang lucyxiang added moderate and removed Theme Sev-2 second highest severity for theme related bug labels Nov 14, 2024
@mgmanzella mgmanzella added Severity: 3 Normal Severity and removed Theme Sev-3 labels Dec 5, 2024
@lukecharle
Copy link

lukecharle commented Dec 28, 2024

Not sure if what I've posted is also related #5146

Is there any news on this being fixed? Its a massive blocker and means I can't use the CLI in my CI/CD pipeline. How else am I supposed to manage themes?

This definitely needs to be marked as high severity and not normal. The CLI isn't usable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: @shopify/theme @shopify/theme package issues Severity: 3 Normal Severity Type: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants