Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: shopify theme dev doesn't work with multipass passwords #4603

Closed
karreiro opened this issue Oct 8, 2024 · 0 comments · Fixed by #4766
Closed

[Bug]: shopify theme dev doesn't work with multipass passwords #4603

karreiro opened this issue Oct 8, 2024 · 0 comments · Fixed by #4766
Assignees
@EvilGenius13
Labels
Area: @shopify/theme @shopify/theme package issues #gsd:40767 Fortify local development experience for Liquid themes Type: Bug Something isn't working

Comments

@karreiro
Copy link
Contributor

karreiro commented Oct 8, 2024 •
edited
Loading

The shopify theme dev command doesn't work with multipass passwords, but it was working in the previous version.

Expected behavior

When users navigate to http://127.0.0.1:9292/account/login/multipass/<token>, it should log in (as it works with --legacy).

Actual behavior

When users navigate to http://127.0.0.1:9292/account/login/multipass/<token>, it presents an error.

Reproduction steps

  1. Generate your multipass token
  2. Open http://127.0.0.1:9292/account/login/multipass/<token>
  3. Notice it doesn't work (but it works with the --legacy flag)
@karreiro karreiro added Type: Bug Something isn't working Area: @shopify/theme @shopify/theme package issues Theme Sev-2 second highest severity for theme related bug #gsd:40767 Fortify local development experience for Liquid themes labels Oct 8, 2024
@karreiro karreiro assigned karreiro and EvilGenius13 and unassigned karreiro Oct 8, 2024
@karreiro karreiro added moderate and removed Theme Sev-2 second highest severity for theme related bug labels Oct 29, 2024
@EvilGenius13 EvilGenius13 mentioned this issue Oct 29, 2024
Merged
5 tasks
@EvilGenius13 EvilGenius13 linked a pull request Oct 29, 2024 that will close this issue
Fix issue with multipass passwords not working with theme dev #4766
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EvilGenius13 EvilGenius13

Labels
Area: @shopify/theme @shopify/theme package issues #gsd:40767 Fortify local development experience for Liquid themes Type: Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix issue with multipass passwords not working with theme dev Shopify/cli
2 participants
@karreiro @EvilGenius13