Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: The contents of this file are auto-generated. #4554

Closed
2 tasks done
magify-expert-shopify opened this issue Oct 1, 2024 · 8 comments
Closed
2 tasks done

[Bug]: The contents of this file are auto-generated. #4554

magify-expert-shopify opened this issue Oct 1, 2024 · 8 comments
Assignees
Labels
Area: @shopify/theme @shopify/theme package issues #gsd:40767 Fortify local development experience for Liquid themes Theme Sev-2 second highest severity for theme related bug Type: Bug Something isn't working

Comments

@magify-expert-shopify
Copy link

Please confirm that you have:

  • Searched existing issues to see if your issue is a duplicate. (If you’ve found a duplicate issue, feel free to add additional information in a comment on it.)
  • Reproduced the issue in the latest CLI version.

In which of these areas are you experiencing a problem?

Theme

Expected behavior

Nothing, just pull my content

Actual behavior

I have this message in start of all my files after pulling.

/*
* ------------------------------------------------------------
* IMPORTANT: The contents of this file are auto-generated.
*
* This file may be updated by the Shopify admin theme editor
* or related systems. Please exercise caution as any changes
* made to this file may be overwritten.
* ------------------------------------------------------------
*/

The message is written multiple times, it's spam.

Verbose output

shopify theme dev --legacy

Reproduction steps

  1. Pull with shopify cli

Operating System

Windows 11

Shopify CLI version (check your project's package.json if you're not sure)

3.67.3

Shell

PowerShell

Node version (run node -v if you're not sure)

v22.5.1

What language and version are you using in your application?

ruby 3.0.6p216 (2023-03-30 revision 23a532679b) [x64-mingw32]

@magify-expert-shopify magify-expert-shopify added the Type: Bug Something isn't working label Oct 1, 2024
@rcasimmons
Copy link

This was introduced with JSON comments being a thing. There is no bug nor is it spam.

@magify-expert-shopify
Copy link
Author

How can I avoid getting this kind of addition with every pull?
Image

@karreiro
Copy link
Contributor

karreiro commented Oct 3, 2024

👋 Hey @magify-expert-shopify,

Thank you for reporting this!

As @rcasimmons mentioned, the headers are expected behavior; they clarify which files may be auto-updated by Shopify and may lose comments and user-defined spaces.

However, they shouldn't be duplicated when pulling, as you shared. I'm investigating this issue, and I will mark this as fixed once it gets resolved.

Thanks again for reporting this!

@karreiro karreiro self-assigned this Oct 3, 2024
@karreiro karreiro added Area: @shopify/theme @shopify/theme package issues Theme Sev-2 second highest severity for theme related bug #gsd:40767 Fortify local development experience for Liquid themes labels Oct 3, 2024
@EvilestVirus7
Copy link

Same issue
Image

@AndrieseiMiruna
Copy link

Same issue, I am not using --theme-editor-sync, but sometimes I need to run shopify theme pull -d to get one small change from the customizer. And I get a lot of frustrating unreal changes
Image

@k0syak

This comment has been minimized.

@karreiro
Copy link
Contributor

👋 Hey folks,

Headers no longer get duplicated. This issue has been resolved at the platform level, so no CLI upgrade is required.

Thank you for reporting this!

@miguel-dango
Copy link

👋 Hey folks,

Headers no longer get duplicated. This issue has been resolved at the platform level, so no CLI upgrade is required.

Thank you for reporting this!

The problem is still in windows.

Image

And I have the latest version of Shopify CLI at the moment

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: @shopify/theme @shopify/theme package issues #gsd:40767 Fortify local development experience for Liquid themes Theme Sev-2 second highest severity for theme related bug Type: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

7 participants