Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some problem about Genome doublings #23

Closed
LongpanUPC opened this issue Aug 9, 2022 · 5 comments
Closed

some problem about Genome doublings #23

LongpanUPC opened this issue Aug 9, 2022 · 5 comments

Comments

@LongpanUPC
Copy link

Dear Shixiang,
thank you very much for creating a useful wrapper to run Absolute. However, I found there may be a problem on colunm "genome doubling" in the final table file. For instance, all the results are 0 in TCGA-LIHC cohort, which menas that there is no genome doubling in this cohort. In fact, it's not ture. Also, from original ABSOLUTE result, we can see nearly 30% of tumor have whole genome doubling. I am not sure if there are some problems when you adapted ABSOLUTE.

best regards,
Long PAN

@ShixiangWang
Copy link
Owner

@LongpanUPC Thanks. I basically don't modify any code regarding the computation. Could you share the ABSOLUTE version and source you used?

Go further, if you have more time, could you help me check the difference between results from the ABSOLUTE you are using and the ABSOLUTE inside the this repository (https://github.com/ShixiangWang/DoAbsolute/blob/master/inst/extdata/ABSOLUTE_1.0.6.tar.gz) with same ABSOLUTE commands and parameters? This can clarify the position with problem.

@LongpanUPC
Copy link
Author

@ShixiangWang ,Hi Shixiang, Sorry for late reply.
In fact, I just compared the result from TCGA pancan project (https://gdc.cancer.gov/about-data/publications/pancanatlas, ABSOLUTE purity/ploidy file - TCGA_mastercalls.abs_tables_JSedit.fixed.txt) with the results generated by Doabsolute (https://zenodo.org/record/5751839#.YvuACXbP2Uk). Also, I used Doabsolute to estimate the ploidy/purity on another liver cancer cohort. Again, all the results are 0 in Genome doubling column.
Your advice is useful and I will test the results according to your advice.

thank you very much!

@ShixiangWang
Copy link
Owner

@LongpanUPC Thank you in advance :). Currently, I have no idea why there is so much difference.

@Yunuuuu
Copy link

Yunuuuu commented Mar 3, 2023

This maybe due to the conflicts between ubuntu openblas or Intel-blas and ABSOLUTE.

I have integrated ABSOLUTE for personal usage in https://github.com/Yunuuuu/biomisc/blob/main/R/run_absolute.R which is modified from DoAbsolute, If I used future to implement parallel process, the results will be strange which I have reported in future issue
HenrikBengtsson/future#649.

I finally decided to run in sequential normal process, as ABSOLUTE can utilize multiple cores though I cannot have much power to adjust to the core number.
image

@ShixiangWang
Copy link
Owner

Hi @Yunuuuu, thanks for your response on this topic and the deep exploration. It helps clarify the mysterious results I never thought could be. I will include this in the README and thank both of you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants