[Bug]: 'Includes checked out assets' warning label is not showing

[jurrejansen]

Contact Details

[email protected]

What happened?

This came to my attention by a report made by one of our users with a Team subscription (Leonardo Finzi from Laerdal Medical).

If 2 bookings include 1 or more of the same asset(s) and these asset(s) have a Checked out status a warning label should appear on the booking entry in the index. I have tested this and this has stopped working.

BEFORE THE START DATE / TIME OF 2ND BOOKING
https://github.com/Shelf-nu/shelf.nu/assets/76112272/fed7152a-9999-4a22-8f65-5ab5d31f8794

AFTER START DATE / TIME OF 2ND BOOKING
https://github.com/Shelf-nu/shelf.nu/assets/76112272/fa18c8a7-6df2-4d45-8688-bf33a1069a1a

What is the expected behaviour?

I am not exactly how was working the last time this was working. I think once the Start date / time of the 2nd booking arrived the warning label started showing.

However, if we have the opportunity to also improve while fixing this I would like to suggest my original approach that was described in the scenario.

Additionally, sending a automated mail to the Administrators of the workspace warning them about a booking that is due for Check-out today and still includes Checked out assets.

Not sure about the complexities of this though.

Version

Hosted (app.shelf.nu)

What browsers are you seeing the problem on?

Chrome

Relevant log output

No response