Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add assets to existing booking from asset page #1245

Open
DonKoko opened this issue Aug 13, 2024 · 6 comments · May be fixed by #1364
Open

Feature: Add assets to existing booking from asset page #1245

DonKoko opened this issue Aug 13, 2024 · 6 comments · May be fixed by #1364
Labels

Comments

@DonKoko
Copy link
Contributor

DonKoko commented Aug 13, 2024

Currently its only possible to create a new booking via the asset page.
We should allow users to add to existing booking as well.

@DonKoko
Copy link
Contributor Author

DonKoko commented Oct 16, 2024

@carlosvirreira can we make a design for this. I have already thought about it and have some ideas:

  1. Button - i think it would be nice to add a button with multiple options on it. Similar to how github does it.
    image
    In this case the options would be: Create new booking or Add to existing
  2. If you select add to existing, we need a modal where the user can select the booking and confirm. It can be a select and it should show only bookings that are in Draft or Reserved state, as those are the only states that allow adding an asset.

@carlosvirreira
Copy link
Contributor

@carlosvirreira can we make a design for this. I have already thought about it and have some ideas:

  1. Button - i think it would be nice to add a button with multiple options on it. Similar to how github does it.
    image
    In this case the options would be: Create new booking or Add to existing
  2. If you select add to existing, we need a modal where the user can select the booking and confirm. It can be a select and it should show only bookings that are in Draft or Reserved state, as those are the only states that allow adding an asset.

This is awesome. Of course we should have it. Let me make a component.

@carlosvirreira
Copy link
Contributor

@DonKoko design suggestions.

Modify the book assets into a combo button with a dropdown. The 'Book asset' just goes to the normal step (create new booking) > dropdown reveals the other option.

If I mis-interpreted your intention let me know. I am not sure if you were looking for this.

Screenshot 2024-10-16 at 18 16 15

Then, expanded dropdown to reveal the booking name and details (start date/time and end date/time)

If you select on 'Add to existing booking' we can show this modified pop-up component we have incorporating the elements.

Screenshot 2024-10-16 at 18 18 43

@DonKoko
Copy link
Contributor Author

DonKoko commented Oct 17, 2024

@carlosvirreira yes, i think the designs are good. Thanks for taking care of it.

@rajeshj11 can you check the designs. Is it clear what the flow is? Keep in mind we dont have support for the button with the multiple possible actions. We have a few components that can be combined to do it. If you decide to take this issue we can discuss on discord how exactly to build it.

@rajeshj11
Copy link
Contributor

@carlosvirreira yes, i think the designs are good. Thanks for taking care of it.

@rajeshj11 can you check the designs. Is it clear what the flow is? Keep in mind we dont have support for the button with the multiple possible actions. We have a few components that can be combined to do it. If you decide to take this issue we can discuss on discord how exactly to build it.

let me check

@rajeshj11
Copy link
Contributor

rajeshj11 commented Oct 17, 2024

@DonKoko I got it what needs to be done for this issue? please ping me the details.

I believe the designs mentioned above are sufficient to begin work.

@rajeshj11 rajeshj11 linked a pull request Oct 18, 2024 that will close this issue
@rajeshj11 rajeshj11 removed their assignment Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 🏗 In progress
Development

Successfully merging a pull request may close this issue.

3 participants