Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ter Mur decorations failing to load #4980

Open
Lexshmyr opened this issue Dec 26, 2021 · 0 comments
Open

Ter Mur decorations failing to load #4980

Lexshmyr opened this issue Dec 26, 2021 · 0 comments

Comments

@Lexshmyr
Copy link

There is a directory change required in /Scripts/Commands/DecorateSA.cs
It is trying to reference subdirectory organization from PUB 57, that do not exist in the PUB 58 (is that what the current master is called?) package. These were reorganized at some point since PUB 57.
The file today references 3 lines, I changed these to a single line and it fixed lots of issues in Ter Mur, Stygian Abyss, the Underworld and Tomb of Kings. It is not 100% functional, but this fix corrected a lot.

Old lines in DecorateSA.cs:
Decorate.Generate("sa", "Data/Decoration/Stygian Abyss/Ter Mur", Map.TerMur);
Decorate.Generate("sa", "Data/Decoration/Stygian Abyss/Trammel", Map.Trammel);
Decorate.Generate("sa", "Data/Decoration/Stygian Abyss/Felucca", Map.Felucca);

New line in DecorateSA.cs:
Decorate.Generate("sa", "Data/Decoration/Ter Mur", Map.TerMur);

Essentially the subdirectory "Stygian Abyss" doesn't exist, but the relevant scripts are in the "Ter Mur" subdirectory.

-This corrected the Stygian Dragon rooms which now have resurrection moongates and the various teleporters to other levels have sparkles.

-Tomb Of Kings has sparkles, has a moongate to enter Stygian Abyss, and Stygian Abyss has a moongate that now functions to exit to Tomb of Kings. The exit teleporters in the main room still do not function to send a character to the entrance - I thought that was the escape, but maybe I am remembering it wrong. This will need more investigation.

-Underworld, doors, teleporters, stairs were all missing before the change, but now these items all are on the map and function.

-Fire Island Casino now spawns (that was later in the DecorateSA.cs script). I did not make any changes other than above, so it seems the script was failing when it couldn't find the missing directory and probably flushing the remaining content.

  • Royal City has both the public forge and the queen's forge (This may fix the reported, open bug from November 7, 2021 about that?).

I found 3 things still missing from the Stygian Abyss
-Tomb of Kings:
-The exit sparkle teleporters from the main room back to the entrance do not function, though these are not decorated with sparkles (prior to the above fix there were no sparkles there).
-There are no chaga mushrooms spawning in the cave corridor leading from the main room to the SA moongate... I do not know if that is related to this, so it needs more investigation.)
-Silver Sapling tree is missing. The XML Spawn object is on the ground, but no tree to give the resurrection seed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant