-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blame info persistent over file change and file close #115
Comments
Hey Wenfang Du! Thank you for the bug report. This is very weird. I have two checks in place that should help prevent this exact behavior. Can you describe your setup a bit more?
|
Operating system: Windows 10 I was mainly doing interactive rebasing to squash and amend commits. |
@Sertion I'm curious does Git Blame reobtain the commit info right after a commit? Because I just tested, even after a simple commit (e.g. edit one line), the |
It is very weird that reopening does not refresh the cache as there is code specifically written for that case. I use fs.watch for detecting if a file changes. Sadly this is sort of the best available. There is nothing in place for detecting commits right now. I don't know how easy it would be to add. |
Would an fs.watch on whatever file |
Could work. The thing to look out for in that case is that a "workspace" can have multiple folders and they can have multiple .git-folders. |
I might have found a fix for the issues discussed here. It would be very valuable for me if @wenfangdu could test the changes before I release them and see if they solve the issues you have experienced. |
Strange, can't reproduce it now, even with v8.1.0. I'll report if I encounter it again. |
@Sertion Sadly, the pre-release didn't fix this issue, this time I was using VSCode v1.59.1. |
Sometimes, after doing a
git rebase
, the git blame info is outdated, reopening the editor won't help, had to reopen the VSCode window to read the latest commit data, is there a way to force Git Blame to use the latest commit data?If there's no way, could you please add an option to do that?
The text was updated successfully, but these errors were encountered: