Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checks java file encoding on windows (PR #75) #76

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Checks java file encoding on windows (PR #75) #76

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
60f92b8
Checks java file encoding on windows (PR #75)
ab3dat Jul 9, 2019
8d1b4dd
Throw exception if file encoding not UTF-8 (PR #75)
ab3dat Jul 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/main/java/ru/serce/jnrfuse/AbstractFuseFS.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,11 @@ public AbstractFuseFS() {
}
break;
case WINDOWS:
String winFspPath = WinPathUtils.getWinFspPath();
if (!System.getProperty("file.encoding").equals("UTF-8"))
{
System.out.println("UTF-8 encoding required! Current encoding: " + System.getProperty("file.encoding"));
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if it's a good idea to print such errors into stdout. That way, we might mess with the stdout of an application which other apps might rely upon.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed it to

    if (!System.getProperty("file.encoding").equals("UTF-8"))
    {	
         throw new FuseException("UTF-8 encoding required! Current encoding: " + System.getProperty("file.encoding"));
     }

Guess that's the better solution. It stops immediately.

Not sure right now, do I have to close this PR and open a new one or are you able to access the new version?

}
String winFspPath = WinPathUtils.getWinFspPath();
libFuse = loader.load(winFspPath);
break;
default:
Expand Down