-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
modal css broken #47
Comments
I was tearing my hair out over this one. I believe the issue has to do with the overzealous rule:
This causes the modal's container to have display: block instead of display: flex. Thus, the modal doesn't flex itself into place properly. See attached photos showing how disabling this rule fixes the positioning: My pen here: https://codepen.io/gpascale/full/VXbxMN/ |
As a temporary workaround, I've stuck the following in my code, and it seems to work:
|
@gpascale perfect timing, thanks for the fix. |
Codepen reproduce
https://codesandbox.io/s/xj4rx88yzz
The text was updated successfully, but these errors were encountered: