Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency in use_remote in master #173

Open
axsaucedo opened this issue Jul 23, 2021 · 0 comments
Open

Inconsistency in use_remote in master #173

axsaucedo opened this issue Jul 23, 2021 · 0 comments

Comments

@axsaucedo
Copy link
Contributor

There is currently a bug / inconsistency in master (which left me puzzled most of the afternoon yesterday as I thought it was introduced in my current change), but seems that there is currently an issue with the relationships between:

  • The type ModelFramework.TempoPipeline (only if explicitly specified, as otherwise it's set to ModelFramework.CUSTOM)
  • The dependent models with custom dependencies of a pipeline
  • The way in which is_remote is used throughout mlserver.py and inside base.py (in tempo)

The issues basically are best reflected when testing the "custom environments background", and is reproducible in master, where the issues are:

  • Individual custom models freeze when sending requests (explained below)
  • Pipeline fails as it tries to load all models locally (or at least it fails with the dependencies from the other two models that are used in the pipeline)

The reason for this is primrily explained below:

  • The models (which don't have internal models) fails as there is a check where any ModelFramework.TempoPipeline get their internal flags set to use_remote / is_remote to true - whilst this is desired for the secondary models, it wouldn't be relevant for subsequent models
  • The pipeline (which calls the two other models) fail as it seems to also require the dependencies from the two other models
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant