Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Args for ODs methods with multiple backends #787

Open
Tracked by #806
mauicv opened this issue May 11, 2023 · 0 comments
Open
Tracked by #806

Args for ODs methods with multiple backends #787

mauicv opened this issue May 11, 2023 · 0 comments
Labels
Type: API Anything affecting the public API (what is exposed, function signatures, return values etc.)
Milestone

Comments

@mauicv
Copy link
Collaborator

mauicv commented May 11, 2023

I feel like we need to revisit how we spec backend-specific arguments. E.g., one needs to carefully read the docstrings (and assume they are correct!) to see which arguments are relevant for the backend choice. This list would become ever more confusing with more backends, so perhaps we need to consider a hierarchical approach, e.g. **pytorch_opts, **sklearn_opts.

Originally posted by @jklaise in #736 (comment)

@mauicv mauicv changed the title Revisit backend-specific argument specs for ods with more that 1 backend Args for ODs methods with multiple backends May 15, 2023
@mauicv mauicv mentioned this issue May 15, 2023
9 tasks
@jklaise jklaise added the Type: API Anything affecting the public API (what is exposed, function signatures, return values etc.) label May 15, 2023
@jklaise jklaise added this to the v0.12.0 milestone May 15, 2023
@mauicv mauicv mentioned this issue Jun 12, 2023
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: API Anything affecting the public API (what is exposed, function signatures, return values etc.)
Projects
None yet
Development

No branches or pull requests

2 participants