Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Arc<str> value #738

Open
stepantubanov opened this issue Jan 12, 2024 · 0 comments
Open

Add support for Arc<str> value #738

stepantubanov opened this issue Jan 12, 2024 · 0 comments

Comments

@stepantubanov
Copy link

Motivation

It's a performance optimization. Currently strings are represented by sea_query::Value::String(Box<String>) which requires a clone if the value is still needed after the query, which means the entire string will be copied. For large values it adds up to significant overhead.

Proposed Solutions

Add enum variant RcString(SeaRc<str>) to sea_query::Value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant