Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issues-721 Add impl IdenStatic and AsRef<str> to #[enum_def] attr #769

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

AndreiOrmanji
Copy link

@AndreiOrmanji AndreiOrmanji commented Apr 15, 2024

PR Info

New Features

  • Copied #[enum_def] to sea-query-derive (and marked #[enum_def] as deprecated at sea-query-attr)
  • Added impl IdenStatic to #[enum_def] of sea-query-derive
  • Added impl AsRef<str> to #[enum_def] of sea-query-derive

@tyt2y3
Copy link
Member

tyt2y3 commented Apr 17, 2024

Hi, as I said in another comment, for long term maintenance I would like to deprecate sea-query-attr and move the macro into sea-query-derive. However, we'll have to migrate to syn2 and probably rename a few things. Would you like to do that?

- added extended version of  `#[enum_def]`  in `sea-query-derive`
- upgraded `darling` crate from 0.14 to 0.20
@AndreiOrmanji AndreiOrmanji force-pushed the feature/issues-721_enum_def_impl_iden_static branch from 7f996cc to d75bf0a Compare April 18, 2024 09:29
@AndreiOrmanji
Copy link
Author

Hi, as I said in another comment, for long term maintenance I would like to deprecate sea-query-attr and move the macro into sea-query-derive. However, we'll have to migrate to syn2 and probably rename a few things. Would you like to do that?

I've done it in d75bf0a.
I'm not sure if I've marked as deprecated correctly, and that's why I did not update CHANGELOG.md and README.md to reflect my changes there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

enum_def could derive IdenStatic
2 participants