You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have searched all issues/PRs to ensure it has not already been reported or fixed.
I have verified that I am using the latest version of Scoop and corresponding bucket.
Package Name
everything-alpha, everything-beta
Expected/Current Behaviour
Using scoop update * to update all applications should continue updating applications even if the update of one fails.
This is already the case, for example if an application is still open.
When updating everything and the pre_uninstall script detects that the Everything service is still open and needs admin permissions to stop, however, the update is completely aborted and the other applications will not attempt to update.
This of course also occours when manually updating multiple applications at once
Steps to Reproduce
S:\
❯ scoop update everything-alpha flow-launchereverything-alpha: 1.5.0.1354a -> 1.5.0.1355aflow-launcher: 1.16.0 -> 1.16.1Updating 2 outdated apps:Updating 'everything-alpha' (1.5.0.1354a -> 1.5.0.1355a)Downloading new versionLoading Everything-1.5.0.1355a.x64.zip from cacheChecking hash of Everything-1.5.0.1355a.x64.zip ... ok.Running pre_uninstall script...ERROR Admin rights are required to stop Everything service
Possible Solution
When encountering that the everything service is still open and admin rights are not present, continue should probably be used instead of break, or scoop needs to add extra handling so that using break in a manifest script does not fully exit.
Replacing break with continue in the pre_uninstall script does not seem to fix the issue. I do not know why. https://github.com/ScoopInstaller/Scoop/blob/master/libexec/scoop-uninstall.ps1#L46-L66
Scoop and Buckets Version
❯ scoop --versionCurrent Scoop version:v0.3.1 - Released at 2022-11-15'extras' bucket:390271a65 (HEAD -> master, origin/master, origin/HEAD) xournalpp: Update to version 1.2.1'games' bucket:f4ea1921 (HEAD -> master, origin/master, origin/HEAD) redream-dev: Update to version 1.5.0-1080-g1053967'java' bucket:dada437d (HEAD -> master, origin/master, origin/HEAD) temurin8-nightly-jre: Update to version 8.0.392-3.0.202308251814'main' bucket:0a2de6658 (HEAD -> master, origin/master, origin/HEAD) tinygo: Update to version 0.29.0'nirsoft-alt' bucket:988ccc8 (HEAD -> master, origin/master, origin/HEAD) Update url list [ci skip]'versions' bucket:1f701c3f9 (HEAD -> master, origin/master, origin/HEAD) vlc-nightly: Update to version 20230826
HUMORCE
changed the title
[Bug]: everything update failure aborts update of multiple apps
[Bug]: everything update failure aborts update of multiple apps
Dec 28, 2023
Prerequisites
Package Name
everything-alpha, everything-beta
Expected/Current Behaviour
Using
scoop update *
to update all applications should continue updating applications even if the update of one fails.This is already the case, for example if an application is still open.
When updating
everything
and thepre_uninstall
script detects that the Everything service is still open and needs admin permissions to stop, however, the update is completely aborted and the other applications will not attempt to update.This of course also occours when manually updating multiple applications at once
Steps to Reproduce
Possible Solution
When encountering that the everything service is still open and admin rights are not present,continue
should probably be used instead ofbreak
, or scoop needs to add extra handling so that usingbreak
in a manifest script does not fully exit.Replacing
break
withcontinue
in the pre_uninstall script does not seem to fix the issue. I do not know why.https://github.com/ScoopInstaller/Scoop/blob/master/libexec/scoop-uninstall.ps1#L46-L66
Scoop and Buckets Version
Scoop Config
PowerShell Version
Additional Softwares
The
extras/everything
package has the same issueThe text was updated successfully, but these errors were encountered: