Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: everything update failure aborts update of multiple apps #1337

Open
3 tasks done
leumasme opened this issue Aug 26, 2023 · 0 comments
Open
3 tasks done

[Bug]: everything update failure aborts update of multiple apps #1337

leumasme opened this issue Aug 26, 2023 · 0 comments

Comments

@leumasme
Copy link

leumasme commented Aug 26, 2023

Prerequisites

  • I have written a descriptive issue title.
  • I have searched all issues/PRs to ensure it has not already been reported or fixed.
  • I have verified that I am using the latest version of Scoop and corresponding bucket.

Package Name

everything-alpha, everything-beta

Expected/Current Behaviour

Using scoop update * to update all applications should continue updating applications even if the update of one fails.
This is already the case, for example if an application is still open.
When updating everything and the pre_uninstall script detects that the Everything service is still open and needs admin permissions to stop, however, the update is completely aborted and the other applications will not attempt to update.
This of course also occours when manually updating multiple applications at once

Steps to Reproduce

S:\scoop update everything-alpha flow-launcher
everything-alpha: 1.5.0.1354a -> 1.5.0.1355a
flow-launcher: 1.16.0 -> 1.16.1
Updating 2 outdated apps:
Updating 'everything-alpha' (1.5.0.1354a -> 1.5.0.1355a)
Downloading new version
Loading Everything-1.5.0.1355a.x64.zip from cache
Checking hash of Everything-1.5.0.1355a.x64.zip ... ok.
Running pre_uninstall script...
ERROR Admin rights are required to stop Everything service

Possible Solution

When encountering that the everything service is still open and admin rights are not present, continue should probably be used instead of break, or scoop needs to add extra handling so that using break in a manifest script does not fully exit.
Replacing break with continue in the pre_uninstall script does not seem to fix the issue. I do not know why.
https://github.com/ScoopInstaller/Scoop/blob/master/libexec/scoop-uninstall.ps1#L46-L66

Scoop and Buckets Version

scoop --version
Current Scoop version:
v0.3.1 - Released at 2022-11-15

'extras' bucket:
390271a65 (HEAD -> master, origin/master, origin/HEAD) xournalpp: Update to version 1.2.1

'games' bucket:
f4ea1921 (HEAD -> master, origin/master, origin/HEAD) redream-dev: Update to version 1.5.0-1080-g1053967

'java' bucket:
dada437d (HEAD -> master, origin/master, origin/HEAD) temurin8-nightly-jre: Update to version 8.0.392-3.0.202308251814

'main' bucket:
0a2de6658 (HEAD -> master, origin/master, origin/HEAD) tinygo: Update to version 0.29.0

'nirsoft-alt' bucket:
988ccc8 (HEAD -> master, origin/master, origin/HEAD) Update url list [ci skip]

'versions' bucket:
1f701c3f9 (HEAD -> master, origin/master, origin/HEAD) vlc-nightly: Update to version 20230826

Scoop Config

scoop config

last_update     : 26.8.2023 13:07:28
aria2-enabled   : False
alias           : @{i=scoop-i; ls=scoop-ls; s=scoop-s; up=scoop-up}
cat_style       : grid,numbers
show_update_log : False
scoop_repo      : https://github.com/lukesampson/scoop
scoop_branch    : master

PowerShell Version

$psversiontable

Name                           Value
----                           -----
PSVersion                      7.3.6
PSEdition                      Core
GitCommitId                    7.3.6
OS                             Microsoft Windows 10.0.19042
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1
WSManStackVersion              3.0

Additional Softwares

The extras/everything package has the same issue

@leumasme leumasme added the bug label Aug 26, 2023
@HUMORCE HUMORCE changed the title [Bug]: everything update failure aborts update of multiple apps [Bug]: everything update failure aborts update of multiple apps Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants