Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coverage upload is failing from forked repositories #5915

Closed
bouweandela opened this issue Apr 17, 2024 · 8 comments
Closed

Coverage upload is failing from forked repositories #5915

bouweandela opened this issue Apr 17, 2024 · 8 comments

Comments

@bouweandela
Copy link
Member

馃悰 Bug Report

The coverage upload to codecov is failing with the following messages:

info - 2024-04-16 14:46:32,664 -- The PR is happening in a forked repo. Using tokenless upload.
info - 2024-04-16 14:46:32,899 -- Process Commit creating complete
error - 2024-04-16 14:46:32,899 -- Commit creating failed: {"detail":"Tokenless has reached GitHub rate limit. Please upload using a token: https://docs.codecov.com/docs/adding-the-codecov-token. Expected available in 749 seconds."}

see e.g. here

@trexfeathers
Copy link
Contributor

You'll be interested to hear that it is coverage that makes testing the latest Python version twice as slow as the other Python versions. Can't tell if it is the coverage processing during testing, or the communication with the codecov service, but the proof is in these two GitHub actions:

  • 8525890403 - where 3.11 was the latest Python version
  • 8694666011 - where 3.12 was the latest Python version

@bouweandela
Copy link
Member Author

Interesting, so it could be coverage collection then. The upload to codecov is a separate step in the workflow, so that is not the cause.

@bjlittle bjlittle self-assigned this Apr 24, 2024
@bjlittle
Copy link
Member

@SciTools/peloton Awaiting whether codecov backtrack or fix this issue for the community.

@trexfeathers
Copy link
Contributor

Can we copy the format used in iris-grib?

      - name: "upload coverage report"
        if: ${{ matrix.coverage }}
        uses: codecov/codecov-action@v4
        with:
          token: ${{ secrets.CODECOV_TOKEN }}

@bjlittle
Copy link
Member

bjlittle commented May 8, 2024

We can give it a try ... I'll push the change 馃憤

@pp-mo
Copy link
Member

pp-mo commented May 8, 2024

Ok @bouweandela, we think #5941 may address this.
Can you easily retry this ?

@bouweandela
Copy link
Member Author

@bouweandela
Copy link
Member Author

Looks like it worked #5926 (comment) now that I pulled in these changes from main 馃コ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

4 participants