Modifies rateinterval API to accept computed urate
.
#288
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A problem with the current implementation of
Coevolve
is that it might computeurate
twice. Once when computing the actualurate
and another time ifrateinterval
callsurate
.This problem is clear in the Hakwes benchmark. Below you can see a profile of the simulation:
This PR modifies the API of
rateinterval
torateinterval(u, p, t, urate)
. With this modification, you can see that much less time is spent inrateinterval
.The downside is a more verbose API. The API will also break for when using
VariableRate
withCoevolve
. However, since the aggregator is relatively new, it might be worth considering this change. I am happy to discuss more elegant alternatives.