Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update unicode "₊" separator to use the default separator variable #949

Open
isaacsas opened this issue Jun 12, 2024 · 4 comments
Open

Comments

@isaacsas
Copy link
Member

isaacsas commented Jun 12, 2024

SciML/ModelingToolkit.jl#2798

We need to propagate this throughout Catalyst where needed (probably some tutorials, tests, and the symmap_to_varmap code). Also need to update to depend on MTK 9.18 or later only.

@isaacsas isaacsas changed the title update unicode + separator to "." update unicode "₊" separator to "." Jun 12, 2024
@ChrisRackauckas
Copy link
Member

#951

@isaacsas
Copy link
Member Author

isaacsas commented Jul 1, 2024

There are still some tests and docs that explicitly use "₊". We need to update them whenever MTK decides to change the separator.

@isaacsas isaacsas reopened this Jul 1, 2024
@ChrisRackauckas
Copy link
Member

Just use the general separator const?

@isaacsas
Copy link
Member Author

isaacsas commented Jul 1, 2024

Yup that is all that needs to be done for the tests, but the doc example will require a bit more tweaking.

@isaacsas isaacsas changed the title update unicode "₊" separator to "." update unicode "₊" separator to use the default separator variable Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants