Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v14 tests broken #824

Closed
isaacsas opened this issue May 13, 2024 · 3 comments
Closed

v14 tests broken #824

isaacsas opened this issue May 13, 2024 · 3 comments

Comments

@isaacsas
Copy link
Member

isaacsas commented May 13, 2024

https://github.com/SciML/Catalyst.jl/actions/runs/9063058490/job/24898215803?pr=823#step:6:1804

This seems due to using replace from Symbolics, which is not exported and probably shouldn't be used.

I have marked the relevant tests as broken for now.

CC: @TorkelE

@isaacsas
Copy link
Member Author

The following tests are being disabled due to this bug in #823 and should be added back as part of fixing this:

@time @safetestset "Coupled CRN/Equation Systems" begin include("reactionsystem_structure/coupled_equation_reaction_systems.jl") end

@time @safetestset "BifurcationKit Extension" begin include("extensions/bifurcation_kit.jl") end

@time @safetestset "HomotopyContinuation Extension" begin include("extensions/homotopy_continuation.jl") end

@time @safetestset "Structural Identifiability Extension" begin include("extensions/structural_identifiability.jl") end

@isaacsas
Copy link
Member Author

I think this is now fixed, but @TorkelE feel free to reopen if it isn't.

@TorkelE
Copy link
Member

TorkelE commented Jun 10, 2024

yes, all fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants