-
-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
supporting connections for compositional modeling #774
Comments
That's effectively the alias elimination pass. Yeah this sounds good. A definition of connection is required though. Maybe it's that any matching species name is matched? |
Isn’t the default usage of |
It seems like the only thing we are missing for compositional modeling to work smoothly is a notion of connections between systems, which here would really just mean aliasing that
sys1.x == sys2.x
, and at some point eliminating one of the two variables in the composedReactionSystem
model. I wonder if we should just reuse the MTK connection object idea, withexpand_connections
handling generating a system that eliminates one variable. The only issue is checking for circular definitions, but I'd imagine maybe we can hook into some of the MTK simplification functionality to make such checks?The text was updated successfully, but these errors were encountered: