-
-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve documentation of remove_conserved
when creating an ODESystem
- and make it default to true
?
#773
Comments
remove_conserved
when creating an ODESystem
remove_conserved
when creating an ODESystem
- and make it default to true
?
Yeah, somehow we never got this more at the fore-front as a feature even though it is in the docs in several places: |
@TorkelE what do you think about defaulting it to true? I know we've discussed but I can't remember if you had a reason not to do it by default for ODEs? |
I don't see a reason to not make it true. Enforcing conservation generally makes the numerics more stable, and structural simplify should then eliminate the equations anyways so we'd get smaller simpler equations to solve. |
OK, we can go with it always being true for ODE models. |
We have just discussed this on Slack. See https://docs.sciml.ai/Catalyst/stable/faqs/#How-to-index-solution-objects-using-symbolic-variables-and-observables?
The text was updated successfully, but these errors were encountered: