Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reenable StructuralIdentifiability tests and tutorial once fixed #1068

Open
isaacsas opened this issue Sep 24, 2024 · 3 comments
Open

Reenable StructuralIdentifiability tests and tutorial once fixed #1068

isaacsas opened this issue Sep 24, 2024 · 3 comments
Labels

Comments

@isaacsas
Copy link
Member

isaacsas commented Sep 24, 2024

#1070 disabled StructuralIdentifiability tests and added a warning in the docs about it having issues. Once they are resolved we should reenable the tests.

@isaacsas isaacsas added the bug label Sep 24, 2024
@isaacsas isaacsas changed the title BifurcationKit tests broken BifurcationKit and HomotopyContinuation tests broken Sep 25, 2024
@isaacsas
Copy link
Member Author

isaacsas commented Oct 3, 2024

To record what has been investigated here, @TorkelE pointed out on Slack this seems to completely hang Julia:

function testSI()
    t = ModelingToolkit.t_nounits
    D = ModelingToolkit.D_nounits
    @variables X(t)
    @parameters p d
    eqs = [
        D(X) ~ p - d*X
    ]
    @mtkbuild osys = ODESystem(eqs, t)
    measured_quantities = [X]    
    funcs_to_check = [osys.p]

    SI.assess_identifiability(osys; measured_quantities, funcs_to_check)
end

Changing to funcs_to_check = [p] seemed to fix the issue. Note I had reported on Slack that removing logging fixed the issue for me, but that doesn't seem to be true currently (so perhaps it was from a polluted environment in some way).

@isaacsas isaacsas changed the title BifurcationKit and HomotopyContinuation tests broken Reenable StructuralIdentifiability tests and tutorial once fixed Oct 3, 2024
@isaacsas
Copy link
Member Author

isaacsas commented Oct 3, 2024

@isaacsas
Copy link
Member Author

isaacsas commented Oct 9, 2024

Docs and extension are fully disabled now via: #1074 (review) so that will need to be reverted when it starts working again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant