-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade API version to V3 #399
Comments
@moltar: Could i migrate API to V3 after finish all issue? |
Yeah, sure! |
@moltar : I have tried to upgrade to V3 with url paths ( Or i skip this issue and start working on another project? |
@nguyentoanit can you please share the docs where you've seen the v2 -> v3 upgrade being mentioned? Thanks. |
@moltar : I found them on Release Note. You can find "Version 3 of the Amazon Advertising API is now available" on Release Note. I tried |
I think the
|
So maybe try:
operations |
I have tried but still get an error.
I couldn't determine which operation do it. |
@moltar : I still have left issue and also reported the result about API V3 on test API above. 👍 |
Hm, which country are you testing this on? I think some of these new API endpoints only work in US for now. |
@moltar : I'm testing on Sandbox API. I don't have a Production token to test. |
Right, but you can still target different countries based by supplying that to an http constructor. How about this. Create a failing test PR and I’ll take a look. |
@moltar: I created a failing test. Please help me take a look it. Thanks. |
From Amazon support:
So, I think it is not possible to use sandbox for testing. In which case, we should just ignore tests for now, and just assume that it works 🤷♂️ |
Hi, any Idea if the sdk will migrate to v3 any time soon? |
@MIT120 There are no plans yet. We have to see how the OpenAPI specs shape up over time. We might use the same approach as we use on the SP API SDK to auto-generate the models from the spec. This would be a one-time, breaking change. |
The v2 endpoints for sponsored product reports are being deprecated next week. If someone needs a solution for now, I've cobbled together a custom operation you can use for V3's Reports:
|
@NiciusB Maybe PR it? ;) |
I started adapting it, but it still needs work improving types and adding operations for all specific report types: https://github.com/ScaleLeap/amazon-advertising-api-sdk/compare/master...NiciusB:amazon-advertising-api-sdk:master?expand=1 If I end up finishing it I'll open a PR |
@NiciusB Do you have it done? Need your help on this my friend :-) |
Do we have any update on V3? Amazon will remove a lot of V2 SP APIs in 6 weeks. |
Currently, we do not have plans to implement additional functionality for v3. |
V2 is deprecating right now, Do you guys have plans on upgrading to v3? |
No description provided.
The text was updated successfully, but these errors were encountered: