Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue converting some songs to MP3 with docker only #199

Open
makew0rld opened this issue Jul 19, 2021 · 2 comments
Open

Issue converting some songs to MP3 with docker only #199

makew0rld opened this issue Jul 19, 2021 · 2 comments
Labels

Comments

@makew0rld
Copy link
Contributor

Describe the bug

When downloading the song Locket by Crumb, only the .webm is downloaded, and it is never converted to MP3. See these logs from docker:

[download] Downloading playlist: Crumb - Locket Lyrics
[youtube:search] query "Crumb - Locket Lyrics": Downloading page 1
[youtube:search] playlist Crumb - Locket Lyrics: Downloading 1 videos
[download] Downloading video 1 of 1
[download] Locket - Crumb (Lyrics) has already been recorded in archive
[download] Finished downloading playlist: Crumb - Locket Lyrics
[download] Downloading playlist: Pond - Paint Me Silver Lyrics
Failed to download: Crumb - Locket Lyrics, please ensure YouTubeDL is up-to-date. 

When running outside of docker, these logs are produced and there is only an MP3 file:

[download] Downloading playlist: Crumb - Locket Lyrics
[youtube:search] query "Crumb - Locket Lyrics": Downloading page 1
[youtube:search] playlist Crumb - Locket Lyrics: Downloading 1 videos
[download] Downloading video 1 of 1
[youtube] X2bQnrmRbWo: Downloading webpage
[youtube] Downloading just video X2bQnrmRbWo because of --no-playlist
[youtube] X2bQnrmRbWo: Downloading MPD manifest
[download] Destination: My Playlist/Crumb - Locket.webm
[download] 100% of 5.39MiB in 00:00
[ffmpeg] Destination: My Playlist/Crumb - Locket.mp3
Deleting original file My Playlist/Crumb - Locket.webm (pass -k to keep)
[download] Finished downloading playlist: Crumb - Locket Lyrics

To Reproduce

docker run -d --rm \
		   -e SPOTIPY_CLIENT_ID=client_id \
		   -e SPOTIPY_CLIENT_SECRET=client_secret \
		   -v "`pwd`":/download \
		   spotify_dl \
		   spotify_dl -l "spotify_playlist_link" -o /download

vs

spotify_dl -l playlist_link -o . -s yes

Just use any playlist with Crumb - Locket in it.

Expected behavior

Docker and non-docker act the same, and both produce MP3 files at the end.

Desktop (please complete the following information):

  • OS: Linux
  • Python version: 3.8 in Docker but 3.9 on my machine. I tried building a Docker image with 3.9 and... the issue was gone!

Hopefully you can figure out why this happens. It'd also be nice to update the docker container to use python:3.9-slim as the base instead of 3.8.

@makew0rld makew0rld added the bug label Jul 19, 2021
@0scvr
Copy link
Contributor

0scvr commented Oct 9, 2021

Can confirm. Having this issue as well with Docker.

@m1ser4ble
Copy link

To convert song to mp3 format, yt-dlp package requires ffmpeg package to be installed.
In my case, the problem resolved after installing it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants