Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding a base color setting #46

Open
pascalduez opened this issue Jan 18, 2015 · 9 comments
Open

Consider adding a base color setting #46

pascalduez opened this issue Jan 18, 2015 · 9 comments

Comments

@pascalduez
Copy link
Member

Following @FWeinb proposal on Slack.

let the user define a base color via config and then calculate needed permutations

@pascalduez pascalduez added this to the SassDoc 2.0 milestone Jan 18, 2015
@pascalduez pascalduez changed the title Consider adding a base color settings Consider adding a base color setting Jan 19, 2015
@KittyGiraudel
Copy link
Member

I'd rather encourage building their own theme.

@eduardoboucas
Copy link
Contributor

I think it'd be great to have the option to define a base colour. In some cases, that may be enough to get the documentation consistent with a project's branding or with other documentation pages, but having to create a theme from scratch — or even fork this one and taking care of maintaining it — is too much of a trouble to achieve that.

@lukassero
Copy link

That would be cool!

@tf
Copy link

tf commented Jan 8, 2016

I would also really like this.

@tf
Copy link

tf commented Jan 8, 2016

Creating one's own theme causes a lot of duplication. Even worse one cannot profit from improvements made to the default theme. What do you think about:

  • Making Sass a dependency of this package
  • Adding a configuration option which allows to supply a path to a custom variables.scss file
  • If present, instead of copying over the assets directory, compile the contents of the scss files from this package together with the given variable overrides during sassdoc run.

This would give a lot of flexibility. The code could eventually even live in sassdoc-extras making it optionally available for other themes as well. Thoughts?

@sudheerDev
Copy link

@hugogiraudel @tf I am looking at customising basic theme. Is there a way to do it?

@KittyGiraudel
Copy link
Member

Right now, you would have to make your own theme. :)

@sudheerDev
Copy link

@hugogiraudel ok thanks. That might be an overkill for me!.

@KittyGiraudel
Copy link
Member

I think it’s a good idea. We’ll happily accept a PR for that. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

6 participants