Add alignment support to vec #1110
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm, I intentionally replaced the old vector code (which had alignment support) with a new simpler vector which simplified code & improved performance (likely due to the reduced memory footprint of table columns). I'm not sure if I want to add that back into the core. My plan for supporting components with >16 byte alignment is pluggable storages, where you'll be able to implement your own data structures / allocation schemes. |
|
ah, yeah that makes sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #478
Changes
This change adds memory alignment support to vec which in turn fixes alignment support for components stored in tables.
Changes to vec.
ecs_size_t alignmentargument alongsideecs_size_t sizeargument in vec API.ecs_vec_tstores bothvoid* arrayandvoid* mem.arrayis the same as before, it is the pointer to the data.memis the original pointer that was allocated, this is used so we have the correct address to be able to realloc or free the memory.size * elem_count + alignmentthis is thevoid* mempointer and then shifts the pointer in order to have the correct alignment forvoid* array.memmovemay be necessary in order to correct for a different alignment of the new pointer.This increases the memory usage of both the vec struct and the allocated arrays.
Since hashmap uses vec internally it also now has alignment support.