-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dark versions for use on white websites #10
Comments
Why wouldn't you just add this as a prop? Seems kind of obvious to build something like this where the colors are configurable. The svg stroke should be updatable IMO. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi @SamHerbert ,
I've forked your repository and am looking to include dark versions (#fff replaced with #000) for all the svg files, as these work great on webpages with white or lighter backgrounds (like the one I am working on right now).
If you would like, I can submit a pull request for this and maybe even include a switch on the
index.html
page to flip to dark versions so users are aware they exist. What do you think?I know it's kind of duplicating things unnecessarily, but it would be really handy for the bower users out there.
If you aren't happy with that I can create a bash script that 'builds' the dark versions by taking the white version, using something like sed and replacing #FFF with #000 in them so when you make changes to the white versions you can simply run the script to build/update the dark versions.
The text was updated successfully, but these errors were encountered: