Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MultiActionButton support element type on text prop #6720

Open
1 task done
StylianosKoidakisSage opened this issue May 7, 2024 · 6 comments
Open
1 task done

MultiActionButton support element type on text prop #6720

StylianosKoidakisSage opened this issue May 7, 2024 · 6 comments

Comments

@StylianosKoidakisSage
Copy link

Description

Same as Button component we should be able to pass an element to the text prop on the MultiActionButton, like so we can place some loaders or icons there

Suggested solution

update the types of MultiActionButton

Demo URL

No response

Alternatives

No response

Additional context

No response

Confidentiality

  • I confirm there is no confidential or commercially sensitive information included.
@nineteen88
Copy link
Contributor

@harpalsingh This doesn't appear to be something actively supported in the DS. Do you think it is something we should support?

@StylianosKoidakisSage Would it be possible to message Harpal and me on Slack with your use case for this? I assume it has come from a UX Designer who wishes to include an icon as part of the button?

@harpalsingh
Copy link
Member

@nineteen88 taking a look at this and will speak with @ljemmo as well

@Parsium
Copy link
Contributor

Parsium commented Jun 4, 2024

Hi @ljemmo @harpalsingh, were you both able to reach a conclusion on this? :)

@ljemmo
Copy link
Contributor

ljemmo commented Aug 6, 2024

@Parsium on my end, i would expect the main trigger on the multi action button to turn into a loading state when required. is this what is proposed? Currently can't see a visual so its hard to know what exactly is requested

@Sage Sage deleted a comment from Parsium Aug 22, 2024
@edleeks87
Copy link
Contributor

edleeks87 commented Aug 22, 2024

Yep @ljemmo is a loading state in the main button that's requested here, I've asked that teams requesting speak to you and potentially generate some designs here

@edleeks87
Copy link
Contributor

FE-6770

@edleeks87 edleeks87 added On Backlog and removed triage Triage Required Design System Review Required DS team to review changes labels Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

6 participants