Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small corrections #42

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Small corrections #42

wants to merge 6 commits into from

Conversation

tcrwt
Copy link

@tcrwt tcrwt commented May 17, 2021

Summary

I've tried to correct some small inconsistencies that I noticed while using this data – please do let me know if anything isn't quite right.

Details

In particular it would be good to check the places where I've added the parsing in TEGMC (once for PRT, and twice towards the bottom of the file for V-RMP-...).

With the bottom two, I wasn't totally sure if the description of the function was complete as the end of the line looked suspect, e.g.:
https://github.com/tyndale/STEPBible-Data/blob/db6d82b0c520c8c82dbdba13a820e113bb3b94e3/TEGMC%20-%20Tyndale%20Expansion%20of%20Greek%20Morphhology%20Codes%20-%20STEPBible.org%20CC%20BY.txt#L7554

I've made this as a pull request for ease of merging, and could squash it into a single 'various fixes' commit if that helps.

tcrwt added 6 commits May 16, 2021 17:17
this one I'm not sure but it looks better than it was
it looks like these are used elsewhere when there's a comma in the function description
DavidIB added a commit that referenced this pull request May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant