-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Differences in excluded fields in objects of a collection cause state of collection diff to be changed #216
Comments
Cc: @robfletcher, @lorin |
比较两个集合对象, 会执行
关键代码:
判断集合中元素是否相同, 默认调用对象的
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi Daniel,
First of all, thanks a lot for the awesome library! We've been using it in open-source Spinnaker for over a year now with great results.
I think I may have run into a corner case. We are configuring a differ in Kotlin like so:
This allows us to use a
@ExcludedFromDiff
annotation to exclude unwanted properties from the diff. This normally works just fine, but I came across a case where, if the objects with excluded fields are part of a collection, and I compare the collection itself, the differ reports a state ofCHANGED
instead of the expectedUNTOUCHED
.For example, this comparison reports
UNTOUCHED
:But this comparison reports
CHANGED
:I've tried my best to debug the issue, but failed. If you have any insights and could at least confirm whether you think this might be a bug and whether there's any workaround in version 0.95, that would be greatly appreciated!
The text was updated successfully, but these errors were encountered: